Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix bug report #508
Date: Thu, 25 Apr 2002 09:04:00 -0000	[thread overview]
Message-ID: <20020425120455.A7896@nevyn.them.org> (raw)
In-Reply-To: <4.2.0.58.20020425094650.016f3410@ics.u-strasbg.fr>

On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
> This is a fix (allmost obvious) to
> the  bug report #508.
> 
> 
> ChangeLog entry:
> 
> 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.

I'd call this obvious, actually.  Please commit it (but add 'Fix PR
gdb/508' above '* symfile.c' in your changelog).

> $ cvs diff -u -p -N symfile.c
> Index: symfile.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symfile.c,v
> retrieving revision 1.59
> diff -u -p -r1.59 symfile.c
> --- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
> +++ symfile.c   24 Apr 2002 22:24:14 -0000
> @@ -1831,8 +1831,9 @@ add_filename_language (char *ext, enum l
>     if (fl_table_next >= fl_table_size)
>       {
>         fl_table_size += 10;
> -      filename_language_table = xrealloc (filename_language_table,
> -                                         fl_table_size);
> +      filename_language_table =
> +       xrealloc (filename_language_table,
> +                 fl_table_size * sizeof (*filename_language_table));
>       }
> 
>     filename_language_table[fl_table_next].ext = xstrdup (ext);
> 
> 
> 
> Pierre Muller
> Institut Charles Sadron
> 6,rue Boussingault
> F 67083 STRASBOURG CEDEX (France)
> mailto:muller@ics.u-strasbg.fr
> Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
> 

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-04-25 16:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-25  0:54 Pierre Muller
2002-04-25  9:04 ` Daniel Jacobowitz [this message]
2002-04-25  9:31   ` Pierre Muller
2002-04-25  9:41   ` Elena Zannoni
2002-04-25  9:53     ` Pierre Muller
2002-04-25  9:56       ` Elena Zannoni
2002-04-25 18:09   ` David S. Miller
2002-04-25 18:17     ` Daniel Jacobowitz
2002-04-25 18:47       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020425120455.A7896@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox