Re: [RFA] Fix bug report #508

[Daniel Jacobowitz <drow@mvista.com>]

On Thu, Apr 25, 2002 at 05:59:51PM -0700, David S. Miller wrote:
>    From: Daniel Jacobowitz <drow@mvista.com>
>    Date: Thu, 25 Apr 2002 12:04:55 -0400
> 
>    On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
>    > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
>    > 
>    > 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.
>    
>    I'd call this obvious, actually.  Please commit it (but add 'Fix PR
>    gdb/508' above '* symfile.c' in your changelog).
> 
> Wait... I was told that an alloca() length argument change
> was anything but obvious.  How is this any different?

The code was reallocing with the number of elements in the array
instead of the size of the array.  That was obvious from my reading of
the patch alone, and made sense with respect to the PR filed yesterday
about this.  If that's not "obvious", I don't know what is.

I don't know what alloca length change you are talking about; I don't
read every message in that depth, although I try.  I have no context to
your complaint, so I can't respond to it.  I happened to read Pierre's,
and I happened to agree completely about his change, so I told him to
commit it under his own authority.  It's not as if I can approve the
bulk of the patches you've been posting!

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer