From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 413 invoked by alias); 26 Apr 2002 01:17:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 352 invoked from network); 26 Apr 2002 01:17:01 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 26 Apr 2002 01:17:01 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 170uMI-0001lL-00; Thu, 25 Apr 2002 21:17:10 -0400 Date: Thu, 25 Apr 2002 18:17:00 -0000 From: Daniel Jacobowitz To: "David S. Miller" Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix bug report #508 Message-ID: <20020425211710.B6519@nevyn.them.org> Mail-Followup-To: "David S. Miller" , gdb-patches@sources.redhat.com References: <4.2.0.58.20020425094650.016f3410@ics.u-strasbg.fr> <20020425120455.A7896@nevyn.them.org> <20020425.175951.106461842.davem@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020425.175951.106461842.davem@redhat.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg01055.txt.bz2 On Thu, Apr 25, 2002 at 05:59:51PM -0700, David S. Miller wrote: > From: Daniel Jacobowitz > Date: Thu, 25 Apr 2002 12:04:55 -0400 > > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote: > > 2002-04-25 Pierre Muller > > > > * symfile.c (add_filename_language): Fix wrong xrealloc size argument. > > I'd call this obvious, actually. Please commit it (but add 'Fix PR > gdb/508' above '* symfile.c' in your changelog). > > Wait... I was told that an alloca() length argument change > was anything but obvious. How is this any different? The code was reallocing with the number of elements in the array instead of the size of the array. That was obvious from my reading of the patch alone, and made sense with respect to the PR filed yesterday about this. If that's not "obvious", I don't know what is. I don't know what alloca length change you are talking about; I don't read every message in that depth, although I try. I have no context to your complaint, so I can't respond to it. I happened to read Pierre's, and I happened to agree completely about his change, so I told him to commit it under his own authority. It's not as if I can approve the bulk of the patches you've been posting! -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer