From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14804-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 26709 invoked by alias); 25 Apr 2002 16:41:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26674 invoked from network); 25 Apr 2002 16:41:34 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 25 Apr 2002 16:41:34 -0000
Received: from localhost.redhat.com (remus.sfbay.redhat.com [172.16.27.252])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id JAA15625
	for <gdb-patches@sources.redhat.com>; Thu, 25 Apr 2002 09:41:34 -0700 (PDT)
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 2B71710A8C; Thu, 25 Apr 2002 12:41:09 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15560.12708.984879.485549@localhost.redhat.com>
Date: Thu, 25 Apr 2002 09:41:00 -0000
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix bug report #508
In-Reply-To: <20020425120455.A7896@nevyn.them.org>
References: <4.2.0.58.20020425094650.016f3410@ics.u-strasbg.fr>
	<20020425120455.A7896@nevyn.them.org>
X-SW-Source: 2002-04/txt/msg01025.txt.bz2

Daniel Jacobowitz writes:
 > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
 > > This is a fix (allmost obvious) to
 > > the  bug report #508.
 > > 
 > > 
 > > ChangeLog entry:
 > > 
 > > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
 > > 
 > > 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.
 > 
 > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
 > gdb/508' above '* symfile.c' in your changelog).

Thanks Daniel,
yes, please commit it.

Elena


 > 
 > > $ cvs diff -u -p -N symfile.c
 > > Index: symfile.c
 > > ===================================================================
 > > RCS file: /cvs/src/src/gdb/symfile.c,v
 > > retrieving revision 1.59
 > > diff -u -p -r1.59 symfile.c
 > > --- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
 > > +++ symfile.c   24 Apr 2002 22:24:14 -0000
 > > @@ -1831,8 +1831,9 @@ add_filename_language (char *ext, enum l
 > >     if (fl_table_next >= fl_table_size)
 > >       {
 > >         fl_table_size += 10;
 > > -      filename_language_table = xrealloc (filename_language_table,
 > > -                                         fl_table_size);
 > > +      filename_language_table =
 > > +       xrealloc (filename_language_table,
 > > +                 fl_table_size * sizeof (*filename_language_table));
 > >       }
 > > 
 > >     filename_language_table[fl_table_next].ext = xstrdup (ext);
 > > 
 > > 
 > > 
 > > Pierre Muller
 > > Institut Charles Sadron
 > > 6,rue Boussingault
 > > F 67083 STRASBOURG CEDEX (France)
 > > mailto:muller@ics.u-strasbg.fr
 > > Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
 > > 
 > 
 > -- 
 > Daniel Jacobowitz                           Carnegie Mellon University
 > MontaVista Software                         Debian GNU/Linux Developer