* [PATCH] Fix PR server/15959
@ 2013-09-17 4:14 Yao Qi
2013-09-17 7:11 ` Agovic, Sanimir
0 siblings, 1 reply; 6+ messages in thread
From: Yao Qi @ 2013-09-17 4:14 UTC (permalink / raw)
To: gdb-patches
When I start gdbserver with option --wrapper, it hangs there. After
some analysis, it is caused by accessing two fields of
'struct thread_resume' which are uninitialized. In server.c:start_inferior,
struct thread_resume resume_info;
resume_info.thread = pid_to_ptid (signal_pid);
resume_info.kind = resume_continue;
resume_info.sig = 0;
fields 'step_range_start' and 'step_range_end' are not initialized, but
they are used in linux-low.c:lwp_in_step_range. This patch is to fix
it by set zero to 'resume_info'.
I find we don't have a test case for option '--wrapper', so I add one.
Even without the fix to server.c, gdb.server/wrapper.exp can pass on
my machine, because the uninitialized contents on stack are
undetermined.
However, fire gdbserver with 'valgrind --track-origins=yes' can report
this problem as:
==13596== Uninitialised value was created by a stack allocation
==13596== at 0x8050D88: start_inferior (server.c:203)
with this patch applied, this message goes away.
gdb/gdbserver:
2013-09-17 Yao Qi <yao@codesourcery.com>
PR server/15959
* server.c (start_inferior): Clear 'resume_info'.
gdb/testsuite/
2013-09-17 Yao Qi <yao@codesourcery.com>
* gdb.server/wrapper.c: New.
* gdb.server/wrapper.exp: New.
---
gdb/gdbserver/server.c | 1 +
gdb/testsuite/gdb.server/wrapper.c | 35 ++++++++++++++++++++++++
gdb/testsuite/gdb.server/wrapper.exp | 48 ++++++++++++++++++++++++++++++++++
3 files changed, 84 insertions(+), 0 deletions(-)
create mode 100644 gdb/testsuite/gdb.server/wrapper.c
create mode 100644 gdb/testsuite/gdb.server/wrapper.exp
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index f4e1525..4de20d5 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -256,6 +256,7 @@ start_inferior (char **argv)
{
struct thread_resume resume_info;
+ memset (&resume_info, 0, sizeof (resume_info));
resume_info.thread = pid_to_ptid (signal_pid);
resume_info.kind = resume_continue;
resume_info.sig = 0;
diff --git a/gdb/testsuite/gdb.server/wrapper.c b/gdb/testsuite/gdb.server/wrapper.c
new file mode 100644
index 0000000..75e8c1d
--- /dev/null
+++ b/gdb/testsuite/gdb.server/wrapper.c
@@ -0,0 +1,35 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2013 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+static char *d = NULL;
+
+static void
+marker (void)
+{}
+
+int
+main(void)
+{
+ d = getenv("TEST");
+
+ marker ();
+
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
new file mode 100644
index 0000000..ee2e430
--- /dev/null
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -0,0 +1,48 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test --wrapper option of GDBserver.
+
+load_lib gdbserver-support.exp
+
+standard_testfile
+
+if { [skip_gdbserver_tests] } {
+ return 0
+}
+
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
+ return -1
+}
+
+# Make sure we're disconnected, in case we're testing with an
+# extended-remote board, therefore already connected.
+gdb_test "disconnect" ".*"
+
+set target_exec [gdbserver_download_current_prog]
+# Start GDBserver with option '--wrapper'.
+set res [gdbserver_start "--wrapper env TEST=1 --" $target_exec]
+
+set gdbserver_protocol [lindex $res 0]
+set gdbserver_gdbport [lindex $res 1]
+gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
+
+gdb_breakpoint marker
+gdb_test "continue" "Breakpoint.* marker .*" "continue to marker"
+# Test env var TEST is correctly passed to the program through
+# --wrapper.
+gdb_test "p d" "\\$${decimal} = ${hex} \"1\".*"
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Fix PR server/15959
2013-09-17 4:14 [PATCH] Fix PR server/15959 Yao Qi
@ 2013-09-17 7:11 ` Agovic, Sanimir
2013-09-17 9:19 ` Yao Qi
0 siblings, 1 reply; 6+ messages in thread
From: Agovic, Sanimir @ 2013-09-17 7:11 UTC (permalink / raw)
To: 'Yao Qi'; +Cc: gdb-patches
This look good to me (though it is not an approval)
Some minor comments below.
-Sanimir
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Yao Qi
> Sent: Tuesday, September 17, 2013 06:13 AM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] Fix PR server/15959
>
> diff --git a/gdb/testsuite/gdb.server/wrapper.c b/gdb/testsuite/gdb.server/wrapper.c
> new file mode 100644
> index 0000000..75e8c1d
> --- /dev/null
> +++ b/gdb/testsuite/gdb.server/wrapper.c
> @@ -0,0 +1,35 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> + Copyright 2013 Free Software Foundation, Inc.
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see <http://www.gnu.org/licenses/>. */
> +
> +#include <stdio.h>
>
Seems this header is not needed.
> diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
> new file mode 100644
> index 0000000..ee2e430
> --- /dev/null
> +++ b/gdb/testsuite/gdb.server/wrapper.exp
> @@ -0,0 +1,48 @@
> [...]
> +
> +if { [skip_gdbserver_tests] } {
> + return 0
> +}
>
Here you use space around the condition, below you don't. At least we should be consistent.
>
> +
> +if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
> + return -1
> +}
> +
> +gdb_test "continue" "Breakpoint.* marker .*" "continue to marker"
> +# Test env var TEST is correctly passed to the program through
> +# --wrapper.
> +gdb_test "p d" "\\$${decimal} = ${hex} \"1\".*"
>
For the sake of maintenance I prefer full spelled commands "p d" vs. "print d". But
this is a matter of taste, so no action is required.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR server/15959
2013-09-17 7:11 ` Agovic, Sanimir
@ 2013-09-17 9:19 ` Yao Qi
2013-09-17 15:57 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Yao Qi @ 2013-09-17 9:19 UTC (permalink / raw)
To: Agovic, Sanimir; +Cc: gdb-patches
Sanimir,
thanks for the review.
On 09/17/2013 03:11 PM, Agovic, Sanimir wrote:
>> +#include <stdio.h>
>> >
> Seems this header is not needed.
>
I'll remove it.
>> >diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
>> >new file mode 100644
>> >index 0000000..ee2e430
>> >--- /dev/null
>> >+++ b/gdb/testsuite/gdb.server/wrapper.exp
>> >@@ -0,0 +1,48 @@
>> >[...]
>> >+
>> >+if { [skip_gdbserver_tests] } {
>> >+ return 0
>> >+}
>> >
> Here you use space around the condition, below you don't. At least we should be consistent.
>> >
OK, fixed. Here is an updated one.
--
Yao (é½å°§)
gdb/gdbserver:
2013-09-17 Yao Qi <yao@codesourcery.com>
PR server/15959
* server.c (start_inferior): Clear 'resume_info'.
gdb/testsuite/
2013-09-17 Yao Qi <yao@codesourcery.com>
* gdb.server/wrapper.c: New.
* gdb.server/wrapper.exp: New.
---
gdb/gdbserver/server.c | 1 +
gdb/testsuite/gdb.server/wrapper.c | 34 ++++++++++++++++++++++++
gdb/testsuite/gdb.server/wrapper.exp | 48 ++++++++++++++++++++++++++++++++++
3 files changed, 83 insertions(+), 0 deletions(-)
create mode 100644 gdb/testsuite/gdb.server/wrapper.c
create mode 100644 gdb/testsuite/gdb.server/wrapper.exp
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index f4e1525..4de20d5 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -256,6 +256,7 @@ start_inferior (char **argv)
{
struct thread_resume resume_info;
+ memset (&resume_info, 0, sizeof (resume_info));
resume_info.thread = pid_to_ptid (signal_pid);
resume_info.kind = resume_continue;
resume_info.sig = 0;
diff --git a/gdb/testsuite/gdb.server/wrapper.c b/gdb/testsuite/gdb.server/wrapper.c
new file mode 100644
index 0000000..fcc73a0
--- /dev/null
+++ b/gdb/testsuite/gdb.server/wrapper.c
@@ -0,0 +1,34 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2013 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <stdlib.h>
+
+static char *d = NULL;
+
+static void
+marker (void)
+{}
+
+int
+main(void)
+{
+ d = getenv("TEST");
+
+ marker ();
+
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
new file mode 100644
index 0000000..a228f6a
--- /dev/null
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -0,0 +1,48 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test --wrapper option of GDBserver.
+
+load_lib gdbserver-support.exp
+
+standard_testfile
+
+if { [skip_gdbserver_tests] } {
+ return 0
+}
+
+if { [prepare_for_testing $testfile.exp $testfile $srcfile debug] } {
+ return -1
+}
+
+# Make sure we're disconnected, in case we're testing with an
+# extended-remote board, therefore already connected.
+gdb_test "disconnect" ".*"
+
+set target_exec [gdbserver_download_current_prog]
+# Start GDBserver with option '--wrapper'.
+set res [gdbserver_start "--wrapper env TEST=1 --" $target_exec]
+
+set gdbserver_protocol [lindex $res 0]
+set gdbserver_gdbport [lindex $res 1]
+gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
+
+gdb_breakpoint marker
+gdb_test "continue" "Breakpoint.* marker .*" "continue to marker"
+# Test env var TEST is correctly passed to the program through
+# --wrapper.
+gdb_test "print d" "\\$${decimal} = ${hex} \"1\".*"
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR server/15959
2013-09-17 9:19 ` Yao Qi
@ 2013-09-17 15:57 ` Pedro Alves
2013-09-18 1:45 ` Yao Qi
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2013-09-17 15:57 UTC (permalink / raw)
To: Yao Qi; +Cc: Agovic, Sanimir, gdb-patches
Thanks Yao.
On 09/17/2013 10:18 AM, Yao Qi wrote:
> +static void
> +marker (void)
> +{}
> +
> +int
> +main(void)
Missing space after parens (you added it in "marker").
> +{
> + d = getenv("TEST");
Here too.
> +
> + marker ();
> +
> + return 0;
> +}
I think the test will fail on Windows, because there's no
"env" binary there. I think we should first try to see
if running "env" works, with "remote_exec target", and
mark the test UNSUPPORTED if it doesn't.
Otherwise it looks good to me.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR server/15959
2013-09-17 15:57 ` Pedro Alves
@ 2013-09-18 1:45 ` Yao Qi
2013-09-18 13:24 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Yao Qi @ 2013-09-18 1:45 UTC (permalink / raw)
To: Pedro Alves; +Cc: Agovic, Sanimir, gdb-patches
On 09/17/2013 11:57 PM, Pedro Alves wrote:
> Missing space after parens (you added it in "marker").
>
>> >+{
>> >+ d = getenv("TEST");
> Here too.
>
Fixed.
>> >+
>> >+ marker ();
>> >+
>> >+ return 0;
>> >+}
> I think the test will fail on Windows, because there's no
> "env" binary there. I think we should first try to see
> if running "env" works, with "remote_exec target", and
> mark the test UNSUPPORTED if it doesn't.
We are testing mingw32 native gdb in cygwin, so "env" is there (shipped
from cygwin), but gdbserver is still unable to create process with
"env TEST=1".
$ gdbserver/gdbserver.exe --wrapper env TEST=1 -- :1234 /bin/ls
Error creating process "env TEST=1 /bin/ls", (error 2): The system
cannot find the file specified.
I mark test unsupported and return on mingw target in the updated patch.
>
> Otherwise it looks good to me.
Below is what I committed.
--
Yao (é½å°§)
gdb/gdbserver:
2013-09-18 Yao Qi <yao@codesourcery.com>
PR server/15959
* server.c (start_inferior): Clear 'resume_info'.
gdb/testsuite/
2013-09-18 Yao Qi <yao@codesourcery.com>
* gdb.server/wrapper.c: New.
* gdb.server/wrapper.exp: New.
---
gdb/gdbserver/server.c | 1 +
gdb/testsuite/gdb.server/wrapper.c | 34 +++++++++++++++++++++
gdb/testsuite/gdb.server/wrapper.exp | 53 ++++++++++++++++++++++++++++++++++
3 files changed, 88 insertions(+), 0 deletions(-)
create mode 100644 gdb/testsuite/gdb.server/wrapper.c
create mode 100644 gdb/testsuite/gdb.server/wrapper.exp
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index f4e1525..4de20d5 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -256,6 +256,7 @@ start_inferior (char **argv)
{
struct thread_resume resume_info;
+ memset (&resume_info, 0, sizeof (resume_info));
resume_info.thread = pid_to_ptid (signal_pid);
resume_info.kind = resume_continue;
resume_info.sig = 0;
diff --git a/gdb/testsuite/gdb.server/wrapper.c b/gdb/testsuite/gdb.server/wrapper.c
new file mode 100644
index 0000000..e98c6a6
--- /dev/null
+++ b/gdb/testsuite/gdb.server/wrapper.c
@@ -0,0 +1,34 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2013 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <stdlib.h>
+
+static char *d = NULL;
+
+static void
+marker (void)
+{}
+
+int
+main (void)
+{
+ d = getenv ("TEST");
+
+ marker ();
+
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
new file mode 100644
index 0000000..5b2e2b7
--- /dev/null
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -0,0 +1,53 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test --wrapper option of GDBserver.
+
+load_lib gdbserver-support.exp
+
+standard_testfile
+
+if { [skip_gdbserver_tests] } {
+ return 0
+}
+
+if [istarget *-*-mingw*] {
+ unsupported "Command env doesn't exist on Windows."
+ return -1
+}
+
+if { [prepare_for_testing $testfile.exp $testfile $srcfile debug] } {
+ return -1
+}
+
+# Make sure we're disconnected, in case we're testing with an
+# extended-remote board, therefore already connected.
+gdb_test "disconnect" ".*"
+
+set target_exec [gdbserver_download_current_prog]
+# Start GDBserver with option '--wrapper'.
+set res [gdbserver_start "--wrapper env TEST=1 --" $target_exec]
+
+set gdbserver_protocol [lindex $res 0]
+set gdbserver_gdbport [lindex $res 1]
+gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
+
+gdb_breakpoint marker
+gdb_test "continue" "Breakpoint.* marker .*" "continue to marker"
+# Test env var TEST is correctly passed to the program through
+# --wrapper.
+gdb_test "print d" "\\$${decimal} = ${hex} \"1\".*"
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR server/15959
2013-09-18 1:45 ` Yao Qi
@ 2013-09-18 13:24 ` Pedro Alves
0 siblings, 0 replies; 6+ messages in thread
From: Pedro Alves @ 2013-09-18 13:24 UTC (permalink / raw)
To: Yao Qi; +Cc: Agovic, Sanimir, gdb-patches
On 09/18/2013 02:44 AM, Yao Qi wrote:
> On 09/17/2013 11:57 PM, Pedro Alves wrote:
>> Missing space after parens (you added it in "marker").
>>
>>>> +{
>>>> + d = getenv("TEST");
>> Here too.
>>
>
> Fixed.
>
>>>> +
>>>> + marker ();
>>>> +
>>>> + return 0;
>>>> +}
>> I think the test will fail on Windows, because there's no
>> "env" binary there. I think we should first try to see
>> if running "env" works, with "remote_exec target", and
>> mark the test UNSUPPORTED if it doesn't.
>
> We are testing mingw32 native gdb in cygwin, so "env" is there (shipped
> from cygwin), but gdbserver is still unable to create process with
> "env TEST=1".
Actually, even though "env" is available on Cygwin, --wrapper doesn't
really work there. --wrapper works by gdbserver expecting more
more exec/trap in the initial create_inferior phase, but the Windows
debug API is different, there are no execs at all like that.
$ ./gdbserver.exe --wrapper /usr/bin/env TEST=1 -- :9999 /usr/bin/echo 1
Process /usr/bin/echo created; pid = 488
1
Child exited with status 0
No program to debug. GDBserver exiting.
$
(gdbserver did one resume too many, and didn't actually end up debugging
the right process)
I've filed PR server/15967 for that.
> I mark test unsupported and return on mingw target in the updated patch.
Thanks. I've applied this follow up.
Subject: [COMMIT PATCH] gdbserver --wrapper also doesn't work on Cygwin.
Skip the test on Cygwin too.
2013-09-18 Pedro Alves <palves@redhat.com>
PR server/15967
* gdb.server/wrapper.exp: Also return unsupported for Cygwin, and
change text.
---
gdb/testsuite/gdb.server/wrapper.exp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
index 5b2e2b7..a5fb714 100644
--- a/gdb/testsuite/gdb.server/wrapper.exp
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -25,8 +25,9 @@ if { [skip_gdbserver_tests] } {
return 0
}
-if [istarget *-*-mingw*] {
- unsupported "Command env doesn't exist on Windows."
+if { [istarget *-*-mingw*]
+ || [istarget *-*-cygwin*] } {
+ unsupported "gdbserver does not support --wrapper on this target (PR server/15967)"
return -1
}
--
1.7.11.7
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-18 13:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-17 4:14 [PATCH] Fix PR server/15959 Yao Qi
2013-09-17 7:11 ` Agovic, Sanimir
2013-09-17 9:19 ` Yao Qi
2013-09-17 15:57 ` Pedro Alves
2013-09-18 1:45 ` Yao Qi
2013-09-18 13:24 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox