From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105372-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32104 invoked by alias); 17 Sep 2013 15:57:56 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 32089 invoked by uid 89); 17 Sep 2013 15:57:55 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2013 15:57:55 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8HFvoPH004012	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 17 Sep 2013 11:57:50 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8HFvmQP006257;	Tue, 17 Sep 2013 11:57:49 -0400
Message-ID: <52387BFC.1010003@redhat.com>
Date: Tue, 17 Sep 2013 15:57:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: "Agovic, Sanimir" <sanimir.agovic@intel.com>,        "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR server/15959
References: <1379391203-14928-1-git-send-email-yao@codesourcery.com> <0377C58828D86C4588AEEC42FC3B85A71767DCAA@IRSMSX105.ger.corp.intel.com> <52381E7A.9000503@codesourcery.com>
In-Reply-To: <52381E7A.9000503@codesourcery.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-09/txt/msg00517.txt.bz2

Thanks Yao.

On 09/17/2013 10:18 AM, Yao Qi wrote:

> +static void
> +marker (void)
> +{}
> +
> +int
> +main(void)

Missing space after parens (you added it in "marker").

> +{
> +  d = getenv("TEST");

Here too.

> +
> +  marker ();
> +
> +  return 0;
> +}

I think the test will fail on Windows, because there's no
"env" binary there.  I think we should first try to see
if running "env" works, with "remote_exec target", and
mark the test UNSUPPORTED if it doesn't.

Otherwise it looks good to me.

-- 
Pedro Alves