From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29911 invoked by alias); 17 Sep 2013 07:11:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29848 invoked by uid 89); 17 Sep 2013 07:11:42 -0000 Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2013 07:11:42 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 17 Sep 2013 00:11:36 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by AZSMGA002.ch.intel.com with ESMTP; 17 Sep 2013 00:11:35 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.29]) by IRSMSX103.ger.corp.intel.com ([163.33.3.157]) with mapi id 14.03.0123.003; Tue, 17 Sep 2013 08:11:11 +0100 From: "Agovic, Sanimir" To: 'Yao Qi' CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] Fix PR server/15959 Date: Tue, 17 Sep 2013 07:11:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A71767DCAA@IRSMSX105.ger.corp.intel.com> References: <1379391203-14928-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1379391203-14928-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00487.txt.bz2 This look good to me (though it is not an approval) Some minor comments below. -Sanimir > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf > Of Yao Qi > Sent: Tuesday, September 17, 2013 06:13 AM > To: gdb-patches@sourceware.org > Subject: [PATCH] Fix PR server/15959 >=20 > diff --git a/gdb/testsuite/gdb.server/wrapper.c b/gdb/testsuite/gdb.serve= r/wrapper.c > new file mode 100644 > index 0000000..75e8c1d > --- /dev/null > +++ b/gdb/testsuite/gdb.server/wrapper.c > @@ -0,0 +1,35 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2013 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see .= */ > + > +#include > Seems this header is not needed. > diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.ser= ver/wrapper.exp > new file mode 100644 > index 0000000..ee2e430 > --- /dev/null > +++ b/gdb/testsuite/gdb.server/wrapper.exp > @@ -0,0 +1,48 @@ > [...] > + > +if { [skip_gdbserver_tests] } { > + return 0 > +} > Here you use space around the condition, below you don't. At least we shoul= d be consistent. > > + > +if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} { > + return -1 > +} > + > +gdb_test "continue" "Breakpoint.* marker .*" "continue to marker" > +# Test env var TEST is correctly passed to the program through > +# --wrapper. > +gdb_test "p d" "\\$${decimal} =3D ${hex} \"1\".*" > For the sake of maintenance I prefer full spelled commands "p d" vs. "print= d". But this is a matter of taste, so no action is required. -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052