From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27682 invoked by alias); 18 Sep 2013 13:24:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27669 invoked by uid 89); 18 Sep 2013 13:24:10 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2013 13:24:10 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8IDO4NR010915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Sep 2013 09:24:05 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r8IDO3t8024973; Wed, 18 Sep 2013 09:24:03 -0400 Message-ID: <5239A972.1040902@redhat.com> Date: Wed, 18 Sep 2013 13:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: "Agovic, Sanimir" , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix PR server/15959 References: <1379391203-14928-1-git-send-email-yao@codesourcery.com> <0377C58828D86C4588AEEC42FC3B85A71767DCAA@IRSMSX105.ger.corp.intel.com> <52381E7A.9000503@codesourcery.com> <52387BFC.1010003@redhat.com> <5239058D.5020400@codesourcery.com> In-Reply-To: <5239058D.5020400@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00585.txt.bz2 On 09/18/2013 02:44 AM, Yao Qi wrote: > On 09/17/2013 11:57 PM, Pedro Alves wrote: >> Missing space after parens (you added it in "marker"). >> >>>> +{ >>>> + d = getenv("TEST"); >> Here too. >> > > Fixed. > >>>> + >>>> + marker (); >>>> + >>>> + return 0; >>>> +} >> I think the test will fail on Windows, because there's no >> "env" binary there. I think we should first try to see >> if running "env" works, with "remote_exec target", and >> mark the test UNSUPPORTED if it doesn't. > > We are testing mingw32 native gdb in cygwin, so "env" is there (shipped > from cygwin), but gdbserver is still unable to create process with > "env TEST=1". Actually, even though "env" is available on Cygwin, --wrapper doesn't really work there. --wrapper works by gdbserver expecting more more exec/trap in the initial create_inferior phase, but the Windows debug API is different, there are no execs at all like that. $ ./gdbserver.exe --wrapper /usr/bin/env TEST=1 -- :9999 /usr/bin/echo 1 Process /usr/bin/echo created; pid = 488 1 Child exited with status 0 No program to debug. GDBserver exiting. $ (gdbserver did one resume too many, and didn't actually end up debugging the right process) I've filed PR server/15967 for that. > I mark test unsupported and return on mingw target in the updated patch. Thanks. I've applied this follow up. Subject: [COMMIT PATCH] gdbserver --wrapper also doesn't work on Cygwin. Skip the test on Cygwin too. 2013-09-18 Pedro Alves PR server/15967 * gdb.server/wrapper.exp: Also return unsupported for Cygwin, and change text. --- gdb/testsuite/gdb.server/wrapper.exp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp index 5b2e2b7..a5fb714 100644 --- a/gdb/testsuite/gdb.server/wrapper.exp +++ b/gdb/testsuite/gdb.server/wrapper.exp @@ -25,8 +25,9 @@ if { [skip_gdbserver_tests] } { return 0 } -if [istarget *-*-mingw*] { - unsupported "Command env doesn't exist on Windows." +if { [istarget *-*-mingw*] + || [istarget *-*-cygwin*] } { + unsupported "gdbserver does not support --wrapper on this target (PR server/15967)" return -1 } -- 1.7.11.7