From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "Agovic, Sanimir" <sanimir.agovic@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR server/15959
Date: Tue, 17 Sep 2013 15:57:00 -0000 [thread overview]
Message-ID: <52387BFC.1010003@redhat.com> (raw)
In-Reply-To: <52381E7A.9000503@codesourcery.com>
Thanks Yao.
On 09/17/2013 10:18 AM, Yao Qi wrote:
> +static void
> +marker (void)
> +{}
> +
> +int
> +main(void)
Missing space after parens (you added it in "marker").
> +{
> + d = getenv("TEST");
Here too.
> +
> + marker ();
> +
> + return 0;
> +}
I think the test will fail on Windows, because there's no
"env" binary there. I think we should first try to see
if running "env" works, with "remote_exec target", and
mark the test UNSUPPORTED if it doesn't.
Otherwise it looks good to me.
--
Pedro Alves
next prev parent reply other threads:[~2013-09-17 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 4:14 Yao Qi
2013-09-17 7:11 ` Agovic, Sanimir
2013-09-17 9:19 ` Yao Qi
2013-09-17 15:57 ` Pedro Alves [this message]
2013-09-18 1:45 ` Yao Qi
2013-09-18 13:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52387BFC.1010003@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox