[PATCH] Use standard_output_file for saved trace file.

[PATCH] Use standard_output_file for saved trace file.

[Yao Qi]

Hi,
During the review of CTF patches, Tom pointed out that we should use
standard_output_file for these generated trace files.  I've done that
in my CTF patches, but find my recent commit in gdb.trace/report.exp
doesn't follow this rule.  This patch is to fix it.

gdb/testsuite:

2013-03-13  Yao Qi  <yao@codesourcery.com>

	* gdb.trace/report.exp: Use standard_output_file for saved
	trace file.
---
 gdb/testsuite/gdb.trace/report.exp |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp
index b32bca1..1ad5696 100644
--- a/gdb/testsuite/gdb.trace/report.exp
+++ b/gdb/testsuite/gdb.trace/report.exp
@@ -406,11 +406,14 @@ gdb_tfind_test "finished: make sure not debugging any trace frame" \
     "none" "-1"
 
 # Save trace frames to tfile.
-gdb_test "tsave report.tf" "Trace data saved to file 'report.tf'.*"
+set tracefile [standard_output_file ${testfile}]
+gdb_test "tsave ${tracefile}.tf" \
+    "Trace data saved to file '${tracefile}.tf'.*" \
+    "save tfile trace file"
 
 # Change target to tfile.
 set test "change to tfile target"
-gdb_test_multiple "target tfile report.tf" "$test" {
+gdb_test_multiple "target tfile ${tracefile}.tf" "$test" {
     -re "A program is being debugged already.  Kill it. .y or n. " {
 	send_gdb "y\n"
 	exp_continue
-- 
1.7.7.6

Re: [PATCH] Use standard_output_file for saved trace file.

[Tom Tromey]

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> During the review of CTF patches, Tom pointed out that we should use
Yao> standard_output_file for these generated trace files.  I've done that
Yao> in my CTF patches, but find my recent commit in gdb.trace/report.exp
Yao> doesn't follow this rule.  This patch is to fix it.

Thanks Yao.  I appreciate this.  FWIW I have a rather large patch (see
archer.git tromey/fully-parallelize-test-suite) that makes this sort of
change globally.  It is always fine to do cleanups like this, and
rebasing my branch is very easy, but if you'd rather just wait for the
eventual submission, that is fine too.

Yao> 2013-03-13  Yao Qi  <yao@codesourcery.com>

Yao> 	* gdb.trace/report.exp: Use standard_output_file for saved
Yao> 	trace file.

Ok.

Tom

Re: [PATCH] Use standard_output_file for saved trace file.

[Yao Qi]

On 03/13/2013 11:08 PM, Tom Tromey wrote:
> Thanks Yao.  I appreciate this.  FWIW I have a rather large patch (see
> archer.git tromey/fully-parallelize-test-suite) that makes this sort of
> change globally.  It is always fine to do cleanups like this, and
> rebasing my branch is very easy, but if you'd rather just wait for the
> eventual submission, that is fine too.
>

CTF patches need this patch, so I committed this patch.  Thanks for the 
review, Tom.

-- 
Yao (齐尧)