From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2774 invoked by alias); 13 Mar 2013 15:09:11 -0000 Received: (qmail 2764 invoked by uid 22791); 13 Mar 2013 15:09:09 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 15:09:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DF8xwR014956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Mar 2013 11:08:59 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2DF8w8k025231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 13 Mar 2013 11:08:58 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Use standard_output_file for saved trace file. References: <1363177865-13834-1-git-send-email-yao@codesourcery.com> Date: Wed, 13 Mar 2013 15:09:00 -0000 In-Reply-To: <1363177865-13834-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 13 Mar 2013 20:31:05 +0800") Message-ID: <878v5rcp6e.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00576.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> During the review of CTF patches, Tom pointed out that we should use Yao> standard_output_file for these generated trace files. I've done that Yao> in my CTF patches, but find my recent commit in gdb.trace/report.exp Yao> doesn't follow this rule. This patch is to fix it. Thanks Yao. I appreciate this. FWIW I have a rather large patch (see archer.git tromey/fully-parallelize-test-suite) that makes this sort of change globally. It is always fine to do cleanups like this, and rebasing my branch is very easy, but if you'd rather just wait for the eventual submission, that is fine too. Yao> 2013-03-13 Yao Qi Yao> * gdb.trace/report.exp: Use standard_output_file for saved Yao> trace file. Ok. Tom