From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Use standard_output_file for saved trace file.
Date: Wed, 13 Mar 2013 12:32:00 -0000 [thread overview]
Message-ID: <1363177865-13834-1-git-send-email-yao@codesourcery.com> (raw)
Hi,
During the review of CTF patches, Tom pointed out that we should use
standard_output_file for these generated trace files. I've done that
in my CTF patches, but find my recent commit in gdb.trace/report.exp
doesn't follow this rule. This patch is to fix it.
gdb/testsuite:
2013-03-13 Yao Qi <yao@codesourcery.com>
* gdb.trace/report.exp: Use standard_output_file for saved
trace file.
---
gdb/testsuite/gdb.trace/report.exp | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp
index b32bca1..1ad5696 100644
--- a/gdb/testsuite/gdb.trace/report.exp
+++ b/gdb/testsuite/gdb.trace/report.exp
@@ -406,11 +406,14 @@ gdb_tfind_test "finished: make sure not debugging any trace frame" \
"none" "-1"
# Save trace frames to tfile.
-gdb_test "tsave report.tf" "Trace data saved to file 'report.tf'.*"
+set tracefile [standard_output_file ${testfile}]
+gdb_test "tsave ${tracefile}.tf" \
+ "Trace data saved to file '${tracefile}.tf'.*" \
+ "save tfile trace file"
# Change target to tfile.
set test "change to tfile target"
-gdb_test_multiple "target tfile report.tf" "$test" {
+gdb_test_multiple "target tfile ${tracefile}.tf" "$test" {
-re "A program is being debugged already. Kill it. .y or n. " {
send_gdb "y\n"
exp_continue
--
1.7.7.6
next reply other threads:[~2013-03-13 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 12:32 Yao Qi [this message]
2013-03-13 15:09 ` Tom Tromey
2013-04-10 18:27 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363177865-13834-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox