From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Use standard_output_file for saved trace file.
Date: Wed, 13 Mar 2013 15:09:00 -0000 [thread overview]
Message-ID: <878v5rcp6e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1363177865-13834-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 13 Mar 2013 20:31:05 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> During the review of CTF patches, Tom pointed out that we should use
Yao> standard_output_file for these generated trace files. I've done that
Yao> in my CTF patches, but find my recent commit in gdb.trace/report.exp
Yao> doesn't follow this rule. This patch is to fix it.
Thanks Yao. I appreciate this. FWIW I have a rather large patch (see
archer.git tromey/fully-parallelize-test-suite) that makes this sort of
change globally. It is always fine to do cleanups like this, and
rebasing my branch is very easy, but if you'd rather just wait for the
eventual submission, that is fine too.
Yao> 2013-03-13 Yao Qi <yao@codesourcery.com>
Yao> * gdb.trace/report.exp: Use standard_output_file for saved
Yao> trace file.
Ok.
Tom
next prev parent reply other threads:[~2013-03-13 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 12:32 Yao Qi
2013-03-13 15:09 ` Tom Tromey [this message]
2013-04-10 18:27 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v5rcp6e.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox