From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14879 invoked by alias); 13 Mar 2013 12:32:47 -0000 Received: (qmail 14847 invoked by uid 22791); 13 Mar 2013 12:32:46 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 12:32:14 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UFkqr-0001Px-OH from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Wed, 13 Mar 2013 05:32:13 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 13 Mar 2013 05:32:13 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Wed, 13 Mar 2013 05:32:12 -0700 From: Yao Qi To: Subject: [PATCH] Use standard_output_file for saved trace file. Date: Wed, 13 Mar 2013 12:32:00 -0000 Message-ID: <1363177865-13834-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00573.txt.bz2 Hi, During the review of CTF patches, Tom pointed out that we should use standard_output_file for these generated trace files. I've done that in my CTF patches, but find my recent commit in gdb.trace/report.exp doesn't follow this rule. This patch is to fix it. gdb/testsuite: 2013-03-13 Yao Qi * gdb.trace/report.exp: Use standard_output_file for saved trace file. --- gdb/testsuite/gdb.trace/report.exp | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp index b32bca1..1ad5696 100644 --- a/gdb/testsuite/gdb.trace/report.exp +++ b/gdb/testsuite/gdb.trace/report.exp @@ -406,11 +406,14 @@ gdb_tfind_test "finished: make sure not debugging any trace frame" \ "none" "-1" # Save trace frames to tfile. -gdb_test "tsave report.tf" "Trace data saved to file 'report.tf'.*" +set tracefile [standard_output_file ${testfile}] +gdb_test "tsave ${tracefile}.tf" \ + "Trace data saved to file '${tracefile}.tf'.*" \ + "save tfile trace file" # Change target to tfile. set test "change to tfile target" -gdb_test_multiple "target tfile report.tf" "$test" { +gdb_test_multiple "target tfile ${tracefile}.tf" "$test" { -re "A program is being debugged already. Kill it. .y or n. " { send_gdb "y\n" exp_continue -- 1.7.7.6