[commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.

[commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.

[Joel Brobecker]

Hello,

The testcase was failing on various 64bit platforms, because the
debugging info said that the target type for a const type is a
4-byte reference.  In the asm file, I used a .long directive, but
the size of .long is of course dependent on the platform.  This
replaces this .long by a .4byte directive.

(observed on ia64-linux and mips-irix, for instance).

gdb/testsuite/ChangeLog:

        * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
        type of our const type.

Tested on x86_64-linux, and checked in.

---
 gdb/testsuite/ChangeLog              |    5 +++++
 gdb/testsuite/gdb.dwarf2/dw2-const.S |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 7b4b6a5..5d04cd9 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-22  Joel Brobecker  <brobecker@adacore.com>
+
+	* gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
+	type of our const type.
+
 2010-09-22  Sami Wagiaalla  <swagiaal@redhat.com>
 
 	* gdb.cp/pr12028.cc: New.
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S
index f5c64f9..aa91839 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-const.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S
@@ -55,7 +55,7 @@ func_cu1:
 
 .Ltype_const:
         .uleb128        0x9                     /* Abbrev: DW_TAG_const_type */
-        .long           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
+        .4byte           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
 
 	/* func_cu1 */
 	.uleb128	2			/* Abbrev: DW_TAG_subprogram */
-- 
1.7.1

Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.

[Michael Snyder]

Joel Brobecker wrote:
> Hello,
> 
> The testcase was failing on various 64bit platforms, because the
> debugging info said that the target type for a const type is a
> 4-byte reference.  In the asm file, I used a .long directive, but
> the size of .long is of course dependent on the platform.  This
> replaces this .long by a .4byte directive.
> 
> (observed on ia64-linux and mips-irix, for instance).
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
>         type of our const type.
> 
> Tested on x86_64-linux, and checked in.
> 
> ---
>  gdb/testsuite/ChangeLog              |    5 +++++
>  gdb/testsuite/gdb.dwarf2/dw2-const.S |    2 +-
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 7b4b6a5..5d04cd9 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2010-09-22  Joel Brobecker  <brobecker@adacore.com>
> +
> +	* gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
> +	type of our const type.
> +
>  2010-09-22  Sami Wagiaalla  <swagiaal@redhat.com>
>  
>  	* gdb.cp/pr12028.cc: New.
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S
> index f5c64f9..aa91839 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-const.S
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S
> @@ -55,7 +55,7 @@ func_cu1:
>  
>  .Ltype_const:
>          .uleb128        0x9                     /* Abbrev: DW_TAG_const_type */
> -        .long           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
> +        .4byte           .Ltype_int-.Lcu1_begin  /* DW_AT_type */

Any reason not to preserve the columnar alignment?

Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

> >-        .long           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
> >+        .4byte           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
> 
> Any reason not to preserve the columnar alignment?

You're right. Fixed thusly:

Thanks,
-- 
Joel

[-- Attachment #2: space.diff --]
[-- Type: text/x-diff, Size: 1232 bytes --]

commit 60f51e794e7da2d2a0dcfdc8b0eed5c1888b12b3
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Wed Sep 22 13:05:22 2010 -0700

    preserve columnar alignment.
    
    gdb/testsuite/ChangeLog:
    
            * gdb.dwarf2/dw2-const.S: Minor (space) reformatting.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 5d04cd9..7ef7fca 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
 2010-09-22  Joel Brobecker  <brobecker@adacore.com>
 
+	* gdb.dwarf2/dw2-const.S: Minor (space) reformatting.
+
+2010-09-22  Joel Brobecker  <brobecker@adacore.com>
+
 	* gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
 	type of our const type.
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S
index aa91839..a5237a1 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-const.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S
@@ -55,7 +55,7 @@ func_cu1:
 
 .Ltype_const:
         .uleb128        0x9                     /* Abbrev: DW_TAG_const_type */
-        .4byte           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
+        .4byte           .Ltype_int-.Lcu1_begin /* DW_AT_type */
 
 	/* func_cu1 */
 	.uleb128	2			/* Abbrev: DW_TAG_subprogram */