Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.
Date: Wed, 22 Sep 2010 19:38:00 -0000	[thread overview]
Message-ID: <4C9A5705.4080604@vmware.com> (raw)
In-Reply-To: <1285182918-6901-1-git-send-email-brobecker@adacore.com>

Joel Brobecker wrote:
> Hello,
> 
> The testcase was failing on various 64bit platforms, because the
> debugging info said that the target type for a const type is a
> 4-byte reference.  In the asm file, I used a .long directive, but
> the size of .long is of course dependent on the platform.  This
> replaces this .long by a .4byte directive.
> 
> (observed on ia64-linux and mips-irix, for instance).
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
>         type of our const type.
> 
> Tested on x86_64-linux, and checked in.
> 
> ---
>  gdb/testsuite/ChangeLog              |    5 +++++
>  gdb/testsuite/gdb.dwarf2/dw2-const.S |    2 +-
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 7b4b6a5..5d04cd9 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2010-09-22  Joel Brobecker  <brobecker@adacore.com>
> +
> +	* gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
> +	type of our const type.
> +
>  2010-09-22  Sami Wagiaalla  <swagiaal@redhat.com>
>  
>  	* gdb.cp/pr12028.cc: New.
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S
> index f5c64f9..aa91839 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-const.S
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S
> @@ -55,7 +55,7 @@ func_cu1:
>  
>  .Ltype_const:
>          .uleb128        0x9                     /* Abbrev: DW_TAG_const_type */
> -        .long           .Ltype_int-.Lcu1_begin  /* DW_AT_type */
> +        .4byte           .Ltype_int-.Lcu1_begin  /* DW_AT_type */

Any reason not to preserve the columnar alignment?


  reply	other threads:[~2010-09-22 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22 19:24 Joel Brobecker
2010-09-22 19:38 ` Michael Snyder [this message]
2010-09-23  7:19   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9A5705.4080604@vmware.com \
    --to=msnyder@vmware.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox