From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12973 invoked by alias); 22 Sep 2010 19:20:49 -0000 Received: (qmail 12962 invoked by uid 22791); 22 Sep 2010 19:20:48 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 19:20:43 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 5A3991C00C; Wed, 22 Sep 2010 12:20:40 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id DFF878E7E5; Wed, 22 Sep 2010 12:20:39 -0700 (PDT) Message-ID: <4C9A5705.4080604@vmware.com> Date: Wed, 22 Sep 2010 19:38:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20100903) MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms. References: <1285182918-6901-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1285182918-6901-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00386.txt.bz2 Joel Brobecker wrote: > Hello, > > The testcase was failing on various 64bit platforms, because the > debugging info said that the target type for a const type is a > 4-byte reference. In the asm file, I used a .long directive, but > the size of .long is of course dependent on the platform. This > replaces this .long by a .4byte directive. > > (observed on ia64-linux and mips-irix, for instance). > > gdb/testsuite/ChangeLog: > > * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target > type of our const type. > > Tested on x86_64-linux, and checked in. > > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.dwarf2/dw2-const.S | 2 +- > 2 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index 7b4b6a5..5d04cd9 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2010-09-22 Joel Brobecker > + > + * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target > + type of our const type. > + > 2010-09-22 Sami Wagiaalla > > * gdb.cp/pr12028.cc: New. > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S > index f5c64f9..aa91839 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-const.S > +++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S > @@ -55,7 +55,7 @@ func_cu1: > > .Ltype_const: > .uleb128 0x9 /* Abbrev: DW_TAG_const_type */ > - .long .Ltype_int-.Lcu1_begin /* DW_AT_type */ > + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ Any reason not to preserve the columnar alignment?