From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.
Date: Thu, 23 Sep 2010 07:19:00 -0000 [thread overview]
Message-ID: <20100922200849.GB3007@adacore.com> (raw)
In-Reply-To: <4C9A5705.4080604@vmware.com>
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
> >- .long .Ltype_int-.Lcu1_begin /* DW_AT_type */
> >+ .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */
>
> Any reason not to preserve the columnar alignment?
You're right. Fixed thusly:
Thanks,
--
Joel
[-- Attachment #2: space.diff --]
[-- Type: text/x-diff, Size: 1232 bytes --]
commit 60f51e794e7da2d2a0dcfdc8b0eed5c1888b12b3
Author: Joel Brobecker <brobecker@adacore.com>
Date: Wed Sep 22 13:05:22 2010 -0700
preserve columnar alignment.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-const.S: Minor (space) reformatting.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 5d04cd9..7ef7fca 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2010-09-22 Joel Brobecker <brobecker@adacore.com>
+ * gdb.dwarf2/dw2-const.S: Minor (space) reformatting.
+
+2010-09-22 Joel Brobecker <brobecker@adacore.com>
+
* gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
type of our const type.
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S
index aa91839..a5237a1 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-const.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S
@@ -55,7 +55,7 @@ func_cu1:
.Ltype_const:
.uleb128 0x9 /* Abbrev: DW_TAG_const_type */
- .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */
+ .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */
/* func_cu1 */
.uleb128 2 /* Abbrev: DW_TAG_subprogram */
prev parent reply other threads:[~2010-09-22 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 19:24 Joel Brobecker
2010-09-22 19:38 ` Michael Snyder
2010-09-23 7:19 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922200849.GB3007@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox