From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21184 invoked by alias); 22 Sep 2010 20:09:04 -0000 Received: (qmail 21158 invoked by uid 22791); 22 Sep 2010 20:08:58 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 20:08:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AAB772BAB68; Wed, 22 Sep 2010 16:08:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4rHOdWQeWVqU; Wed, 22 Sep 2010 16:08:51 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4D43C2BAB16; Wed, 22 Sep 2010 16:08:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4B022F591E; Wed, 22 Sep 2010 13:08:49 -0700 (PDT) Date: Thu, 23 Sep 2010 07:19:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms. Message-ID: <20100922200849.GB3007@adacore.com> References: <1285182918-6901-1-git-send-email-brobecker@adacore.com> <4C9A5705.4080604@vmware.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <4C9A5705.4080604@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00397.txt.bz2 --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 242 > >- .long .Ltype_int-.Lcu1_begin /* DW_AT_type */ > >+ .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > > Any reason not to preserve the columnar alignment? You're right. Fixed thusly: Thanks, -- Joel --DocE+STaALJfprDB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="space.diff" Content-length: 1232 commit 60f51e794e7da2d2a0dcfdc8b0eed5c1888b12b3 Author: Joel Brobecker Date: Wed Sep 22 13:05:22 2010 -0700 preserve columnar alignment. gdb/testsuite/ChangeLog: * gdb.dwarf2/dw2-const.S: Minor (space) reformatting. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5d04cd9..7ef7fca 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2010-09-22 Joel Brobecker + * gdb.dwarf2/dw2-const.S: Minor (space) reformatting. + +2010-09-22 Joel Brobecker + * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target type of our const type. diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S index aa91839..a5237a1 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-const.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S @@ -55,7 +55,7 @@ func_cu1: .Ltype_const: .uleb128 0x9 /* Abbrev: DW_TAG_const_type */ - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ /* func_cu1 */ .uleb128 2 /* Abbrev: DW_TAG_subprogram */ --DocE+STaALJfprDB--