[PATCH] PPC atomic single stepping testcase

[PATCH] PPC atomic single stepping testcase

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Hi Folks,

The fix for the PPC single stepping through atomic sequences is already
upstream, but currently there's no testcase for it. Follows a patch to
add a testcase to check for that problem. It's been sitting in my system
for a while since it needed a fix, but should be OK now.

Comments?

Best regards,
Luis

[-- Attachment #2: ppc-atomic-sequences-testcase.diff --]
[-- Type: text/x-patch, Size: 3939 bytes --]

2007-12-04  Luis Machado  <luisgpm@br.ibm.com>

    * gdb.arch/powerpc64-atomic-single-stepping.c: New testcase source file.
    * gdb.arch/powerpc64-atomic-single-stepping.exp: New testcase expect file.

Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c	2007-12-04 10:21:12.000000000 -0800
@@ -0,0 +1,30 @@
+/* This file is part of GDB, the GNU debugger.
+
+   Copyright 2007 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+
+void hello ()
+{
+  printf ("Hello, world!\n");
+}
+
+int main()
+{
+  hello();
+
+  return 0;
+}
Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp	2007-12-04 10:22:06.000000000 -0800
@@ -0,0 +1,71 @@
+# Copyright 2006 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel {
+    strace $tracelevel
+}
+
+# Test single stepping through atomic sequences beginning with
+# a lwarx/ldarx instruction and ending with a stwcx/stdcx
+# instruction.
+
+set prms_id 0
+set bug_id 0
+
+if ![istarget "powerpc64-*"] then {
+    verbose "Skipping powerpc64 single stepping over atomic sequences testing."
+    return
+}
+
+set testfile "powerpc64-atomic-single-stepping"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set compile_flags "debug"
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ${compile_flags}] != "" } {
+    unsupported "Testcase compile failed."
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "Couldn't run to breakpoint"
+    continue
+}
+
+gdb_test "x/g &puts" "$hex <puts>:\[\t\]+$hex" \
+  "Get the address of the puts function"
+
+gdb_breakpoint "*(\$__ + 88)" "Breakpoint $decimal at $hex" \
+  "Set the breakpoint at the start of the sequence"
+
+gdb_test continue "Continuing.*Breakpoint $decimal.*" \
+  "Continue until breakpoint"
+
+gdb_test "x/i \$pc" "$hex <.*>:\[\t\]+lwarx.*" \
+  "Check for the lwarx instruction to be stepped"
+
+gdb_test "stepi" "$hex in \._IO_puts \\(\\) from .*" \
+  "Step through the atomic sequence"
+
+gdb_test "x/i (\$pc - 4)" "$hex <.*>:\[\t\]+stwcx.*" \
+  "Check for stepped stcwx instruction"

[PATCH] PPC atomic single stepping testcase

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Hi Folks,

The fix for the PPC single stepping through atomic sequences is already
upstream, but currently there's no testcase for it. Follows a patch to
add a testcase to check for that problem. It's been sitting in my system
for a while since it needed a fix, but should be OK now.

Comments?

Best regards,
Luis

[-- Attachment #2: ppc-atomic-sequences-testcase.diff --]
[-- Type: text/x-patch, Size: 3939 bytes --]

2007-12-04  Luis Machado  <luisgpm@br.ibm.com>

    * gdb.arch/powerpc64-atomic-single-stepping.c: New testcase source file.
    * gdb.arch/powerpc64-atomic-single-stepping.exp: New testcase expect file.

Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c	2007-12-04 10:21:12.000000000 -0800
@@ -0,0 +1,30 @@
+/* This file is part of GDB, the GNU debugger.
+
+   Copyright 2007 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+
+void hello ()
+{
+  printf ("Hello, world!\n");
+}
+
+int main()
+{
+  hello();
+
+  return 0;
+}
Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp	2007-12-04 10:22:06.000000000 -0800
@@ -0,0 +1,71 @@
+# Copyright 2006 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel {
+    strace $tracelevel
+}
+
+# Test single stepping through atomic sequences beginning with
+# a lwarx/ldarx instruction and ending with a stwcx/stdcx
+# instruction.
+
+set prms_id 0
+set bug_id 0
+
+if ![istarget "powerpc64-*"] then {
+    verbose "Skipping powerpc64 single stepping over atomic sequences testing."
+    return
+}
+
+set testfile "powerpc64-atomic-single-stepping"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set compile_flags "debug"
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ${compile_flags}] != "" } {
+    unsupported "Testcase compile failed."
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "Couldn't run to breakpoint"
+    continue
+}
+
+gdb_test "x/g &puts" "$hex <puts>:\[\t\]+$hex" \
+  "Get the address of the puts function"
+
+gdb_breakpoint "*(\$__ + 88)" "Breakpoint $decimal at $hex" \
+  "Set the breakpoint at the start of the sequence"
+
+gdb_test continue "Continuing.*Breakpoint $decimal.*" \
+  "Continue until breakpoint"
+
+gdb_test "x/i \$pc" "$hex <.*>:\[\t\]+lwarx.*" \
+  "Check for the lwarx instruction to be stepped"
+
+gdb_test "stepi" "$hex in \._IO_puts \\(\\) from .*" \
+  "Step through the atomic sequence"
+
+gdb_test "x/i (\$pc - 4)" "$hex <.*>:\[\t\]+stwcx.*" \
+  "Check for stepped stcwx instruction"

Re: [PATCH] PPC atomic single stepping testcase

[Ulrich Weigand]

Luis Machado wrote:

> +gdb_test "x/g &puts" "$hex <puts>:\[\t\]+$hex" \
> +  "Get the address of the puts function"
> +
> +gdb_breakpoint "*(\$__ + 88)" "Breakpoint $decimal at $hex" \
> +  "Set the breakpoint at the start of the sequence"

This appears to make quite a lot of assumptions about
glibc implementation details.  I'd except just about
any glibc update to break this test ...

As this is a PowerPC-specific case anyway, can you not
use a test that explicitly has the atomic sequence in
the code provided with the test case?

Bye,
Ulrich


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] PPC atomic single stepping testcase

[Luis Machado]

> Luis Machado wrote:
> 
> > +gdb_test "x/g &puts" "$hex <puts>:\[\t\]+$hex" \
> > +  "Get the address of the puts function"
> > +
> > +gdb_breakpoint "*(\$__ + 88)" "Breakpoint $decimal at $hex" \
> > +  "Set the breakpoint at the start of the sequence"
> 
> This appears to make quite a lot of assumptions about
> glibc implementation details.  I'd except just about
> any glibc update to break this test ...
> 
> As this is a PowerPC-specific case anyway, can you not
> use a test that explicitly has the atomic sequence in
> the code provided with the test case?
> 

Yes, you're probably right. I'll provide something more
glibc-independent.

Regards,
Luis

Re: [PATCH] PPC atomic single stepping testcase

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

> This appears to make quite a lot of assumptions about
> glibc implementation details.  I'd except just about
> any glibc update to break this test ...
> 
> As this is a PowerPC-specific case anyway, can you not
> use a test that explicitly has the atomic sequence in
> the code provided with the test case?

Testcase updated, making use of explicit atomic sequences for 64-bit
binaries.

This testcase handles stepping through atomic sequences only. The
related problem with threads and atomic sequences will be handled in a
different testcase.

OK to commit?

Regards,
Luis

[-- Attachment #2: ppc-atomic-sequences-testcase.diff --]
[-- Type: text/x-patch, Size: 4794 bytes --]

2007-12-10  Luis Machado  <luisgpm@br.ibm.com>

    * gdb.arch/powerpc64-atomic-single-stepping.c: New testcase source file.
    * gdb.arch/powerpc64-atomic-single-stepping.exp: New testcase expect file.

Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c	2007-12-10 08:16:11.000000000 -0800
@@ -0,0 +1,44 @@
+/* This file is part of GDB, the GNU debugger.
+
+   Copyright 2007 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+
+int main()
+{
+  unsigned int word = 0;
+  unsigned int *word_addr = &word;
+  unsigned long dword = 0;
+  unsigned long *dword_addr = &dword;
+
+  __asm __volatile ("1:     lwarx   %0,0,%2\n"              \
+                    "       addi    %0,%0,1\n"              \
+                    "       stwcx.  %0,0,%2\n"              \
+                    "       bne-    1b"			    \
+                    : "=&b" (word), "=m" (*word_addr)       \
+                    : "b" (word_addr), "m" (*word_addr)     \
+                    : "cr0", "memory");			    \
+
+  __asm __volatile ("1:     ldarx   %0,0,%2\n"              \
+                    "       addi    %0,%0,1\n"              \
+                    "       stdcx.  %0,0,%2\n"              \
+                    "       bne-    1b"                     \
+                    : "=&b" (dword), "=m" (*dword_addr)     \
+                    : "b" (dword_addr), "m" (*dword_addr)   \
+                    : "cr0", "memory");                     \
+
+  return 0;
+}
Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp	2007-12-10 08:36:43.000000000 -0800
@@ -0,0 +1,71 @@
+# Copyright 2006 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel {
+    strace $tracelevel
+}
+
+# Test single stepping through atomic sequences beginning with
+# a lwarx/ldarx instruction and ending with a stwcx/stdcx
+# instruction.
+
+set prms_id 0
+set bug_id 0
+
+if ![istarget "powerpc64-*"] then {
+    verbose "Skipping powerpc64 single stepping over atomic sequences testing."
+    return
+}
+
+set testfile "powerpc64-atomic-single-stepping"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set compile_flags "debug"
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [concat debug additional_flags=-m64]] != "" } {
+    unsupported "Testcase compile failed."
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "Couldn't run to breakpoint"
+    continue
+}
+
+gdb_breakpoint "27" "Breakpoint $decimal at $hex" \
+  "Set the breakpoint at the start of the sequence"
+
+gdb_breakpoint "35" "Breakpoint $decimal at $hex" \
+  "Set the breakpoint at the start of the sequence"
+
+gdb_test continue "Continuing.*Breakpoint $decimal.*" \
+  "Continue until breakpoint"
+
+gdb_test next "" \
+  "Step through the lwarx/stwcx sequence"
+
+gdb_test next "" \
+  "Step through the ldarx/stdcx sequence"
+
+gdb_test continue ".*Program exited normally.*" \
+  "Continue until exit"

Re: [PATCH] PPC atomic single stepping testcase

[Daniel Jacobowitz]

On Mon, Dec 10, 2007 at 02:44:52PM -0200, Luis Machado wrote:
>     * gdb.arch/powerpc64-atomic-single-stepping.c: New testcase source file.
>     * gdb.arch/powerpc64-atomic-single-stepping.exp: New testcase expect file.

Is there a shorter name you could give this? :-(

> @@ -0,0 +1,71 @@
> +# Copyright 2006 Free Software Foundation, Inc.

2007.

> +gdb_breakpoint "27" "Breakpoint $decimal at $hex" \
> +  "Set the breakpoint at the start of the sequence"
> +
> +gdb_breakpoint "35" "Breakpoint $decimal at $hex" \
> +  "Set the breakpoint at the start of the sequence"

Take a look at gdb_get_line_number.

> +gdb_test continue "Continuing.*Breakpoint $decimal.*" \
> +  "Continue until breakpoint"
> +
> +gdb_test next "" \
> +  "Step through the lwarx/stwcx sequence"
> +
> +gdb_test next "" \
> +  "Step through the ldarx/stdcx sequence"

That's not much of a test.  I suggest you match enough output
to verify that you ended up where you expected to.

> +gdb_test continue ".*Program exited normally.*" \
> +  "Continue until exit"

Is this testing for anything specific?  Otherwise, I'd recommend not
doing it; some targets produce different exit messages, et cetera.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH] PPC atomic single stepping testcase

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

Fixed with all the points you've mentioned. Is this OK or is there a
more robust way to check if GDB hangs while stepping through the
sequences?

Best regards,

-- 
Luis Machado
Software Engineer 
IBM Linux Technology Center

[-- Attachment #2: ppc-atomic-sequences-testcase.diff --]
[-- Type: text/x-patch, Size: 4579 bytes --]

2007-12-18  Luis Machado  <luisgpm@br.ibm.com>

    * gdb.arch/ppc64-atomic-inst.c: New testcase source file.
    * gdb.arch/ppc64-atomic-inst.exp: New testcase expect file.

Index: gdb/testsuite/gdb.arch/ppc64-atomic-inst.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/ppc64-atomic-inst.c	2007-12-18 10:17:34.000000000 -0800
@@ -0,0 +1,44 @@
+/* This file is part of GDB, the GNU debugger.
+
+   Copyright 2007 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+
+int main()
+{
+  unsigned int word = 0;
+  unsigned int *word_addr = &word;
+  unsigned long dword = 0;
+  unsigned long *dword_addr = &dword;
+
+  __asm __volatile ("1:     lwarx   %0,0,%2\n"              \
+                    "       addi    %0,%0,1\n"              \
+                    "       stwcx.  %0,0,%2\n"              \
+                    "       bne-    1b"			    \
+                    : "=&b" (word), "=m" (*word_addr)       \
+                    : "b" (word_addr), "m" (*word_addr)     \
+                    : "cr0", "memory");			    \
+
+  __asm __volatile ("1:     ldarx   %0,0,%2\n"              \
+                    "       addi    %0,%0,1\n"              \
+                    "       stdcx.  %0,0,%2\n"              \
+                    "       bne-    1b"                     \
+                    : "=&b" (dword), "=m" (*dword_addr)     \
+                    : "b" (dword_addr), "m" (*dword_addr)   \
+                    : "cr0", "memory");                     \
+
+  return 0;
+}
Index: gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp	2007-12-18 10:18:36.000000000 -0800
@@ -0,0 +1,66 @@
+# Copyright 2007 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel {
+    strace $tracelevel
+}
+
+# Test single stepping through atomic sequences beginning with
+# a lwarx/ldarx instruction and ending with a stwcx/stdcx
+# instruction.
+
+set prms_id 0
+set bug_id 0
+
+if ![istarget "powerpc64-*"] then {
+    verbose "Skipping testing of powerpc64 single stepping over atomic sequences."
+    return
+}
+
+set testfile "ppc64-atomic-inst"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set compile_flags "debug"
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [concat debug additional_flags=-m64]] != "" } {
+    unsupported "Testcase compile failed."
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "Couldn't run to breakpoint"
+    continue
+}
+
+set bp1 [gdb_get_line_number "lwarx"]
+gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \
+  "Set the breakpoint at the start of the sequence"
+
+gdb_test continue "Continuing.*Breakpoint $decimal.*" \
+  "Continue until breakpoint"
+
+gdb_test next ".*__asm __volatile.*" \
+  "Step through the lwarx/stwcx sequence"
+
+gdb_test next ".*return 0.*" \
+  "Step through the ldarx/stdcx sequence"

Re: [PATCH] PPC atomic single stepping testcase

[Luis Machado]

Any comments on this one?

Regards,

On Tue, 2007-12-18 at 16:27 -0200, Luis Machado wrote:
> Fixed with all the points you've mentioned. Is this OK or is there a
> more robust way to check if GDB hangs while stepping through the
> sequences?
> 
> Best regards,
> 
-- 
Luis Machado
Software Engineer 
IBM Linux Technology Center

Re: [PATCH] PPC atomic single stepping testcase

[Daniel Jacobowitz]

On Tue, Dec 18, 2007 at 04:27:01PM -0200, Luis Machado wrote:
> Fixed with all the points you've mentioned. Is this OK or is there a
> more robust way to check if GDB hangs while stepping through the
> sequences?
> 
> Best regards,
> 
> -- 
> Luis Machado
> Software Engineer 
> IBM Linux Technology Center

> 2007-12-18  Luis Machado  <luisgpm@br.ibm.com>
> 
>     * gdb.arch/ppc64-atomic-inst.c: New testcase source file.
>     * gdb.arch/ppc64-atomic-inst.exp: New testcase expect file.

Looks OK to me; please update the years to 2008.


-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH] PPC atomic single stepping testcase

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

> Looks OK to me; please update the years to 2008.

Thanks. I've checked this version in.

-- 
Luis Machado
Software Engineer 
IBM Linux Technology Center

[-- Attachment #2: ppc-atomic-sequences-testcase.diff --]
[-- Type: text/x-patch, Size: 4579 bytes --]

2008-01-31  Luis Machado  <luisgpm@br.ibm.com>

    * gdb.arch/ppc64-atomic-inst.c: New testcase source file.
    * gdb.arch/ppc64-atomic-inst.exp: New testcase expect file.

Index: gdb/testsuite/gdb.arch/ppc64-atomic-inst.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/ppc64-atomic-inst.c	2008-01-31 07:35:24.000000000 -0800
@@ -0,0 +1,44 @@
+/* This file is part of GDB, the GNU debugger.
+
+   Copyright 2008 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+
+int main()
+{
+  unsigned int word = 0;
+  unsigned int *word_addr = &word;
+  unsigned long dword = 0;
+  unsigned long *dword_addr = &dword;
+
+  __asm __volatile ("1:     lwarx   %0,0,%2\n"              \
+                    "       addi    %0,%0,1\n"              \
+                    "       stwcx.  %0,0,%2\n"              \
+                    "       bne-    1b"			    \
+                    : "=&b" (word), "=m" (*word_addr)       \
+                    : "b" (word_addr), "m" (*word_addr)     \
+                    : "cr0", "memory");			    \
+
+  __asm __volatile ("1:     ldarx   %0,0,%2\n"              \
+                    "       addi    %0,%0,1\n"              \
+                    "       stdcx.  %0,0,%2\n"              \
+                    "       bne-    1b"                     \
+                    : "=&b" (dword), "=m" (*dword_addr)     \
+                    : "b" (dword_addr), "m" (*dword_addr)   \
+                    : "cr0", "memory");                     \
+
+  return 0;
+}
Index: gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp	2008-01-31 07:35:30.000000000 -0800
@@ -0,0 +1,66 @@
+# Copyright 2008 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+if $tracelevel {
+    strace $tracelevel
+}
+
+# Test single stepping through atomic sequences beginning with
+# a lwarx/ldarx instruction and ending with a stwcx/stdcx
+# instruction.
+
+set prms_id 0
+set bug_id 0
+
+if ![istarget "powerpc64-*"] then {
+    verbose "Skipping testing of powerpc64 single stepping over atomic sequences."
+    return
+}
+
+set testfile "ppc64-atomic-inst"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+set compile_flags "debug"
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [concat debug additional_flags=-m64]] != "" } {
+    unsupported "Testcase compile failed."
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "Couldn't run to breakpoint"
+    continue
+}
+
+set bp1 [gdb_get_line_number "lwarx"]
+gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \
+  "Set the breakpoint at the start of the sequence"
+
+gdb_test continue "Continuing.*Breakpoint $decimal.*" \
+  "Continue until breakpoint"
+
+gdb_test next ".*__asm __volatile.*" \
+  "Step through the lwarx/stwcx sequence"
+
+gdb_test next ".*return 0.*" \
+  "Step through the ldarx/stdcx sequence"

Re: [PATCH] PPC atomic single stepping testcase

[Thiago Jung Bauermann]

On Mon, 2007-12-10 at 14:44 -0200, Luis Machado wrote:
> OK to commit?

> Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp
> ===================================================================
> --- /dev/null   1970-01-01 00:00:00.000000000 +0000
> +++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp
2007-12-10 08:36:43.000000000 -0800
> @@ -0,0 +1,71 @@
> +# Copyright 2006 Free Software Foundation, Inc.
> +#
> +# This program is free software; you can redistribute it and/or
modify
> +# it under the terms of the GNU General Public License as published
by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.

This should be GPL v3.
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center