From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1589 invoked by alias); 10 Dec 2007 16:45:16 -0000 Received: (qmail 1578 invoked by uid 22791); 10 Dec 2007 16:45:15 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Dec 2007 16:44:57 +0000 Received: from mailhub3.br.ibm.com (unknown [9.18.232.110]) by igw3.br.ibm.com (Postfix) with ESMTP id 937E439000E for ; Mon, 10 Dec 2007 14:38:40 -0200 (BRDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBAGisSV3440724 for ; Mon, 10 Dec 2007 14:44:54 -0200 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBAGishZ029737 for ; Mon, 10 Dec 2007 14:44:54 -0200 Received: from [9.18.198.2] ([9.18.198.2]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lBAGird2029708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 10 Dec 2007 14:44:53 -0200 Subject: Re: [PATCH] PPC atomic single stepping testcase From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: gdb-patches@sourceware.org In-Reply-To: <200712042316.lB4NGkjV014646@d12av02.megacenter.de.ibm.com> References: <200712042316.lB4NGkjV014646@d12av02.megacenter.de.ibm.com> Content-Type: multipart/mixed; boundary="=-7sR878lWHT5KRlc/2OfL" Date: Mon, 10 Dec 2007 17:31:00 -0000 Message-Id: <1197305093.2060.17.camel@gargoyle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00153.txt.bz2 --=-7sR878lWHT5KRlc/2OfL Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 577 > This appears to make quite a lot of assumptions about > glibc implementation details. I'd except just about > any glibc update to break this test ... > > As this is a PowerPC-specific case anyway, can you not > use a test that explicitly has the atomic sequence in > the code provided with the test case? Testcase updated, making use of explicit atomic sequences for 64-bit binaries. This testcase handles stepping through atomic sequences only. The related problem with threads and atomic sequences will be handled in a different testcase. OK to commit? Regards, Luis --=-7sR878lWHT5KRlc/2OfL Content-Disposition: attachment; filename=ppc-atomic-sequences-testcase.diff Content-Type: text/x-patch; name=ppc-atomic-sequences-testcase.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 4794 2007-12-10 Luis Machado * gdb.arch/powerpc64-atomic-single-stepping.c: New testcase source file. * gdb.arch/powerpc64-atomic-single-stepping.exp: New testcase expect file. Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.c 2007-12-10 08:16:11.000000000 -0800 @@ -0,0 +1,44 @@ +/* This file is part of GDB, the GNU debugger. + + Copyright 2007 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include + +int main() +{ + unsigned int word = 0; + unsigned int *word_addr = &word; + unsigned long dword = 0; + unsigned long *dword_addr = &dword; + + __asm __volatile ("1: lwarx %0,0,%2\n" \ + " addi %0,%0,1\n" \ + " stwcx. %0,0,%2\n" \ + " bne- 1b" \ + : "=&b" (word), "=m" (*word_addr) \ + : "b" (word_addr), "m" (*word_addr) \ + : "cr0", "memory"); \ + + __asm __volatile ("1: ldarx %0,0,%2\n" \ + " addi %0,%0,1\n" \ + " stdcx. %0,0,%2\n" \ + " bne- 1b" \ + : "=&b" (dword), "=m" (*dword_addr) \ + : "b" (dword_addr), "m" (*dword_addr) \ + : "cr0", "memory"); \ + + return 0; +} Index: gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ gdb/testsuite/gdb.arch/powerpc64-atomic-single-stepping.exp 2007-12-10 08:36:43.000000000 -0800 @@ -0,0 +1,71 @@ +# Copyright 2006 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. +# +# This file is part of the gdb testsuite. + +if $tracelevel { + strace $tracelevel +} + +# Test single stepping through atomic sequences beginning with +# a lwarx/ldarx instruction and ending with a stwcx/stdcx +# instruction. + +set prms_id 0 +set bug_id 0 + +if ![istarget "powerpc64-*"] then { + verbose "Skipping powerpc64 single stepping over atomic sequences testing." + return +} + +set testfile "powerpc64-atomic-single-stepping" +set srcfile ${testfile}.c +set binfile ${objdir}/${subdir}/${testfile} +set compile_flags "debug" + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [concat debug additional_flags=-m64]] != "" } { + unsupported "Testcase compile failed." + return -1 +} + +gdb_exit +gdb_start +gdb_reinitialize_dir $srcdir/$subdir +gdb_load ${binfile} + +if ![runto_main] then { + perror "Couldn't run to breakpoint" + continue +} + +gdb_breakpoint "27" "Breakpoint $decimal at $hex" \ + "Set the breakpoint at the start of the sequence" + +gdb_breakpoint "35" "Breakpoint $decimal at $hex" \ + "Set the breakpoint at the start of the sequence" + +gdb_test continue "Continuing.*Breakpoint $decimal.*" \ + "Continue until breakpoint" + +gdb_test next "" \ + "Step through the lwarx/stwcx sequence" + +gdb_test next "" \ + "Step through the ldarx/stdcx sequence" + +gdb_test continue ".*Program exited normally.*" \ + "Continue until exit" --=-7sR878lWHT5KRlc/2OfL--