From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18474 invoked by alias); 16 Dec 2007 22:25:40 -0000 Received: (qmail 18466 invoked by uid 22791); 16 Dec 2007 22:25:40 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 22:25:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C5B5898151; Sun, 16 Dec 2007 22:25:32 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A77199811F; Sun, 16 Dec 2007 22:25:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J41vP-0001rG-WD; Sun, 16 Dec 2007 17:25:32 -0500 Date: Sun, 16 Dec 2007 22:49:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] PPC atomic single stepping testcase Message-ID: <20071216222531.GA6846@caradoc.them.org> Mail-Followup-To: Luis Machado , gdb-patches@sourceware.org References: <200712042316.lB4NGkjV014646@d12av02.megacenter.de.ibm.com> <1197305093.2060.17.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1197305093.2060.17.camel@gargoyle> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00241.txt.bz2 On Mon, Dec 10, 2007 at 02:44:52PM -0200, Luis Machado wrote: > * gdb.arch/powerpc64-atomic-single-stepping.c: New testcase source file. > * gdb.arch/powerpc64-atomic-single-stepping.exp: New testcase expect file. Is there a shorter name you could give this? :-( > @@ -0,0 +1,71 @@ > +# Copyright 2006 Free Software Foundation, Inc. 2007. > +gdb_breakpoint "27" "Breakpoint $decimal at $hex" \ > + "Set the breakpoint at the start of the sequence" > + > +gdb_breakpoint "35" "Breakpoint $decimal at $hex" \ > + "Set the breakpoint at the start of the sequence" Take a look at gdb_get_line_number. > +gdb_test continue "Continuing.*Breakpoint $decimal.*" \ > + "Continue until breakpoint" > + > +gdb_test next "" \ > + "Step through the lwarx/stwcx sequence" > + > +gdb_test next "" \ > + "Step through the ldarx/stdcx sequence" That's not much of a test. I suggest you match enough output to verify that you ended up where you expected to. > +gdb_test continue ".*Program exited normally.*" \ > + "Continue until exit" Is this testing for anything specific? Otherwise, I'd recommend not doing it; some targets produce different exit messages, et cetera. -- Daniel Jacobowitz CodeSourcery