From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28183 invoked by alias); 18 Dec 2007 18:27:22 -0000 Received: (qmail 28175 invoked by uid 22791); 18 Dec 2007 18:27:21 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Dec 2007 18:27:06 +0000 Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) by igw1.br.ibm.com (Postfix) with ESMTP id 99ACC32C19B for ; Tue, 18 Dec 2007 16:07:30 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBIIR3gj4329552 for ; Tue, 18 Dec 2007 16:27:03 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBIIR3vD023826 for ; Tue, 18 Dec 2007 16:27:03 -0200 Received: from [9.18.238.20] ([9.18.238.20]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lBIIR3j7023815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Dec 2007 16:27:03 -0200 Subject: Re: [PATCH] PPC atomic single stepping testcase From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org In-Reply-To: <20071216222531.GA6846@caradoc.them.org> References: <200712042316.lB4NGkjV014646@d12av02.megacenter.de.ibm.com> <1197305093.2060.17.camel@gargoyle> <20071216222531.GA6846@caradoc.them.org> Content-Type: multipart/mixed; boundary="=-ToNnDgvVs2E8P4fdfMgi" Date: Tue, 18 Dec 2007 18:47:00 -0000 Message-Id: <1198002422.1209.6.camel@gargoyle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00291.txt.bz2 --=-ToNnDgvVs2E8P4fdfMgi Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 225 Fixed with all the points you've mentioned. Is this OK or is there a more robust way to check if GDB hangs while stepping through the sequences? Best regards, -- Luis Machado Software Engineer IBM Linux Technology Center --=-ToNnDgvVs2E8P4fdfMgi Content-Disposition: attachment; filename=ppc-atomic-sequences-testcase.diff Content-Type: text/x-patch; name=ppc-atomic-sequences-testcase.diff; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 4579 2007-12-18 Luis Machado * gdb.arch/ppc64-atomic-inst.c: New testcase source file. * gdb.arch/ppc64-atomic-inst.exp: New testcase expect file. Index: gdb/testsuite/gdb.arch/ppc64-atomic-inst.c =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ gdb/testsuite/gdb.arch/ppc64-atomic-inst.c 2007-12-18 10:17:34.000000000 -0800 @@ -0,0 +1,44 @@ +/* This file is part of GDB, the GNU debugger. + + Copyright 2007 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include + +int main() +{ + unsigned int word = 0; + unsigned int *word_addr = &word; + unsigned long dword = 0; + unsigned long *dword_addr = &dword; + + __asm __volatile ("1: lwarx %0,0,%2\n" \ + " addi %0,%0,1\n" \ + " stwcx. %0,0,%2\n" \ + " bne- 1b" \ + : "=&b" (word), "=m" (*word_addr) \ + : "b" (word_addr), "m" (*word_addr) \ + : "cr0", "memory"); \ + + __asm __volatile ("1: ldarx %0,0,%2\n" \ + " addi %0,%0,1\n" \ + " stdcx. %0,0,%2\n" \ + " bne- 1b" \ + : "=&b" (dword), "=m" (*dword_addr) \ + : "b" (dword_addr), "m" (*dword_addr) \ + : "cr0", "memory"); \ + + return 0; +} Index: gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp 2007-12-18 10:18:36.000000000 -0800 @@ -0,0 +1,66 @@ +# Copyright 2007 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. +# +# This file is part of the gdb testsuite. + +if $tracelevel { + strace $tracelevel +} + +# Test single stepping through atomic sequences beginning with +# a lwarx/ldarx instruction and ending with a stwcx/stdcx +# instruction. + +set prms_id 0 +set bug_id 0 + +if ![istarget "powerpc64-*"] then { + verbose "Skipping testing of powerpc64 single stepping over atomic sequences." + return +} + +set testfile "ppc64-atomic-inst" +set srcfile ${testfile}.c +set binfile ${objdir}/${subdir}/${testfile} +set compile_flags "debug" + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [concat debug additional_flags=-m64]] != "" } { + unsupported "Testcase compile failed." + return -1 +} + +gdb_exit +gdb_start +gdb_reinitialize_dir $srcdir/$subdir +gdb_load ${binfile} + +if ![runto_main] then { + perror "Couldn't run to breakpoint" + continue +} + +set bp1 [gdb_get_line_number "lwarx"] +gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ + "Set the breakpoint at the start of the sequence" + +gdb_test continue "Continuing.*Breakpoint $decimal.*" \ + "Continue until breakpoint" + +gdb_test next ".*__asm __volatile.*" \ + "Step through the lwarx/stwcx sequence" + +gdb_test next ".*return 0.*" \ + "Step through the ldarx/stdcx sequence" --=-ToNnDgvVs2E8P4fdfMgi--