[COMMIT] Obvious - compilation failure in proc-api.c

[COMMIT] Obvious - compilation failure in proc-api.c

[David Lecomber]

Dear all,

It's been a while since I committed something, but here's one for the
obvious fix rule.   Someone prod me if I forgot to do something ;-)  

The old version failed to compile with Sun's Forte tools on Solaris 10
for Opteron (and you should've seen the code formatting!) 

Regards
David

2005-03-09  David Lecomber  <david@lecomber.net>
 
        * proc-api.c (_initialize_proc_api): Fix invalid multi-line
        i18n text.


Index: proc-api.c
===================================================================
RCS file: /cvs/src/src/gdb/proc-api.c,v
retrieving revision 1.22
retrieving revision 1.23
diff -c -p -r1.22 -r1.23
*** proc-api.c  18 Feb 2005 15:25:27 -0000      1.22
--- proc-api.c  9 Mar 2005 23:33:52 -0000       1.23
*************** _initialize_proc_api (void)
*** 780,795 ****
  {
    struct cmd_list_element *c;
   
!   add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace,
_("\
! Set tracing for /proc api calls."), _("\
! Show tracing for /proc api calls."), NULL,
                           set_procfs_trace_cmd,
                           NULL, /* FIXME: i18n: */
                           &setlist, &showlist);
   
!   add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename,
_("\
! Set filename for /proc tracefile."), _("\
! Show filename for /proc tracefile."), NULL,
                            set_procfs_file_cmd,
                            NULL, /* FIXME: i18n: */
                            &setlist, &showlist);
--- 780,795 ----
  {
    struct cmd_list_element *c;
   
!   add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace,
!                          _("Set tracing for /proc api calls."),
!                          _("Show tracing for /proc api calls."), NULL,
                           set_procfs_trace_cmd,
                           NULL, /* FIXME: i18n: */
                           &setlist, &showlist);
   
!   add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename,
!                           _("Set filename for /proc tracefile."),
!                           _("Show filename for /proc tracefile."),
NULL,
                            set_procfs_file_cmd,
                            NULL, /* FIXME: i18n: */
                            &setlist, &showlist);

-- 
David Lecomber <david@allinea.com>

Re: [COMMIT] Obvious - compilation failure in proc-api.c

[Daniel Jacobowitz]

On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote:
> Dear all,
> 
> It's been a while since I committed something, but here's one for the
> obvious fix rule.   Someone prod me if I forgot to do something ;-)  
> 
> The old version failed to compile with Sun's Forte tools on Solaris 10
> for Opteron (and you should've seen the code formatting!) 

What was the error?  The style appears to be the same as the one Andrew
used all across GDB when he mass-converted.

(Yes, I think it's ugly.)

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [COMMIT] Obvious - compilation failure in proc-api.c

[David Lecomber]

On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote:
> On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote:
> > Dear all,
> > 
> > It's been a while since I committed something, but here's one for the
> > obvious fix rule.   Someone prod me if I forgot to do something ;-)  
> > 
> > The old version failed to compile with Sun's Forte tools on Solaris 10
> > for Opteron (and you should've seen the code formatting!) 
> 
> What was the error?  The style appears to be the same as the one Andrew
> used all across GDB when he mass-converted.
> 
> (Yes, I think it's ugly.)

Well, it's only been that file that has complained, but the error was
pretty straight forward:

/opt/SUNWspro/bin/cc -c -xtarget=opteron -xarch=amd64     -I. -I.././gdb
-I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
-DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/..
-I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl
-I.././gdb/../intl  -DMI_OUT=1   proc-api.c
"proc-api.c", line 783: newline in string literal
"proc-api.c", line 786: syntax error before or at: set_procfs_trace_cmd
"proc-api.c", line 796: cannot recover from previous errors
cc: acomp failed for proc-api.c
make[1]: *** [proc-api.o] Error 2
make[1]: Leaving directory
`/home/david/Sun/64bit/gdb-6.3.50.20050304/gdb'
make: *** [all-gdb] Error 2

d.
-- 
David Lecomber <david@allinea.com>

Re: [COMMIT] Obvious - compilation failure in proc-api.c

[Daniel Jacobowitz]

On Thu, Mar 10, 2005 at 12:09:36AM +0000, David Lecomber wrote:
> On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote:
> > On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote:
> > > Dear all,
> > > 
> > > It's been a while since I committed something, but here's one for the
> > > obvious fix rule.   Someone prod me if I forgot to do something ;-)  
> > > 
> > > The old version failed to compile with Sun's Forte tools on Solaris 10
> > > for Opteron (and you should've seen the code formatting!) 
> > 
> > What was the error?  The style appears to be the same as the one Andrew
> > used all across GDB when he mass-converted.
> > 
> > (Yes, I think it's ugly.)
> 
> Well, it's only been that file that has complained, but the error was
> pretty straight forward:
> 
> /opt/SUNWspro/bin/cc -c -xtarget=opteron -xarch=amd64     -I. -I.././gdb
> -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
> -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/..
> -I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl
> -I.././gdb/../intl  -DMI_OUT=1   proc-api.c
> "proc-api.c", line 783: newline in string literal
> "proc-api.c", line 786: syntax error before or at: set_procfs_trace_cmd
> "proc-api.c", line 796: cannot recover from previous errors

Hmm, maybe I just couldn't see the mistake.  Oh well.  Or there may
have been a space after one of the backslashes; GCC handles this as a
QoI extension.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [COMMIT] Obvious - compilation failure in proc-api.c

[Mark Kettenis]

   Date: Wed, 9 Mar 2005 20:01:18 -0500
   From: Daniel Jacobowitz <drow@false.org>

   On Thu, Mar 10, 2005 at 12:09:36AM +0000, David Lecomber wrote:
   > On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote:
   > > On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote:
   > > > Dear all,
   > > > 
   > > > It's been a while since I committed something, but here's one for the
   > > > obvious fix rule.   Someone prod me if I forgot to do something ;-)  
   > > > 
   > > > The old version failed to compile with Sun's Forte tools on Solaris 10
   > > > for Opteron (and you should've seen the code formatting!) 
   > > 
   > > What was the error?  The style appears to be the same as the one Andrew
   > > used all across GDB when he mass-converted.
   > > 
   > > (Yes, I think it's ugly.)

The style has its benefits (but we should discuss that some other time
if we feel like it, althouh I think we should use a consistent style).

   Hmm, maybe I just couldn't see the mistake.  Oh well.  Or there may
   have been a space after one of the backslashes; GCC handles this as a
   QoI extension.

That was the exact problem.  So I reverted David's patch (no offence
meant) and remoced the trailing space.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* proc-api.c: Update copyright year.
	(_initialize_proc_api): Revert previous patch, removing spurious
	space instead.

Index: proc-api.c
===================================================================
RCS file: /cvs/src/src/gdb/proc-api.c,v
retrieving revision 1.23
diff -u -p -r1.23 proc-api.c
--- proc-api.c 9 Mar 2005 23:33:52 -0000 1.23
+++ proc-api.c 10 Mar 2005 09:08:27 -0000
@@ -1,6 +1,6 @@
 /* Machine independent support for SVR4 /proc (process file system) for GDB.
 
-   Copyright 1999, 2000, 2001, 2003 Free Software Foundation, Inc.
+   Copyright 1999, 2000, 2001, 2003, 2005 Free Software Foundation, Inc.
 
    Written by Michael Snyder at Cygnus Solutions.
    Based on work by Fred Fish, Stu Grossman, Geoff Noer, and others.
@@ -780,16 +780,16 @@ _initialize_proc_api (void)
 {
   struct cmd_list_element *c;
 
-  add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace,
-			   _("Set tracing for /proc api calls."),
-			   _("Show tracing for /proc api calls."), NULL,
+  add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace, _("\
+Set tracing for /proc api calls."), _("\
+Show tracing for /proc api calls."), NULL,
 			   set_procfs_trace_cmd,
 			   NULL, /* FIXME: i18n: */
 			   &setlist, &showlist);
 
-  add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename,
-			    _("Set filename for /proc tracefile."),
-			    _("Show filename for /proc tracefile."), NULL,
+  add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename, _("\
+Set filename for /proc tracefile."), _("\
+Show filename for /proc tracefile."), NULL,
 			    set_procfs_file_cmd,
 			    NULL, /* FIXME: i18n: */
 			    &setlist, &showlist);