From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31984 invoked by alias); 10 Mar 2005 00:02:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31819 invoked from network); 10 Mar 2005 00:01:45 -0000 Received: from unknown (HELO webmail.streamline-computing.com) (82.133.39.164) by sourceware.org with SMTP; 10 Mar 2005 00:01:45 -0000 Received: from [80.6.111.103] (helo=cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com) by webmail.streamline-computing.com with asmtp (Exim 3.35 #1 (Debian)) id 1D9B7m-0006S5-00; Thu, 10 Mar 2005 00:01:58 +0000 Subject: Re: [COMMIT] Obvious - compilation failure in proc-api.c From: David Lecomber To: Daniel Jacobowitz Cc: patches In-Reply-To: <20050309234126.GA5799@nevyn.them.org> References: <1110411905.8084.34.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> <20050309234126.GA5799@nevyn.them.org> Content-Type: text/plain Date: Thu, 10 Mar 2005 00:02:00 -0000 Message-Id: <1110413377.8084.40.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00163.txt.bz2 On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote: > On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote: > > Dear all, > > > > It's been a while since I committed something, but here's one for the > > obvious fix rule. Someone prod me if I forgot to do something ;-) > > > > The old version failed to compile with Sun's Forte tools on Solaris 10 > > for Opteron (and you should've seen the code formatting!) > > What was the error? The style appears to be the same as the one Andrew > used all across GDB when he mass-converted. > > (Yes, I think it's ugly.) Well, it's only been that file that has complained, but the error was pretty straight forward: /opt/SUNWspro/bin/cc -c -xtarget=opteron -xarch=amd64 -I. -I.././gdb -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/.. -I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl -I.././gdb/../intl -DMI_OUT=1 proc-api.c "proc-api.c", line 783: newline in string literal "proc-api.c", line 786: syntax error before or at: set_procfs_trace_cmd "proc-api.c", line 796: cannot recover from previous errors cc: acomp failed for proc-api.c make[1]: *** [proc-api.o] Error 2 make[1]: Leaving directory `/home/david/Sun/64bit/gdb-6.3.50.20050304/gdb' make: *** [all-gdb] Error 2 d. -- David Lecomber