From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2015 invoked by alias); 10 Mar 2005 09:17:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1946 invoked from network); 10 Mar 2005 09:17:02 -0000 Received: from unknown (HELO server7.nfra.nl) (192.87.1.57) by sourceware.org with SMTP; 10 Mar 2005 09:17:02 -0000 Received: from jop31.nfra.nl ([10.87.10.31]) by server7.nfra.nl; Thu, 10 Mar 2005 10:16:35 +0100 Received: from jop31.nfra.nl (localhost [127.0.0.1]) by jop31.nfra.nl (8.13.1/8.12.7/SuSE Linux 0.6) with ESMTP id j2A9GGDJ015735; Thu, 10 Mar 2005 10:16:26 +0100 Received: (from kettenis@localhost) by jop31.nfra.nl (8.13.1/8.13.1/Submit) id j2A9GGN7015732; Thu, 10 Mar 2005 10:16:16 +0100 Date: Thu, 10 Mar 2005 09:17:00 -0000 Message-Id: <200503100916.j2A9GGN7015732@jop31.nfra.nl> From: Mark Kettenis To: drow@false.org CC: david@allinea.com, gdb-patches@sources.redhat.com In-reply-to: <20050310010118.GA8356@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 9 Mar 2005 20:01:18 -0500) Subject: Re: [COMMIT] Obvious - compilation failure in proc-api.c References: <1110411905.8084.34.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> <20050309234126.GA5799@nevyn.them.org> <1110413377.8084.40.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> <20050310010118.GA8356@nevyn.them.org> X-SW-Source: 2005-03/txt/msg00169.txt.bz2 Date: Wed, 9 Mar 2005 20:01:18 -0500 From: Daniel Jacobowitz On Thu, Mar 10, 2005 at 12:09:36AM +0000, David Lecomber wrote: > On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote: > > On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote: > > > Dear all, > > > > > > It's been a while since I committed something, but here's one for the > > > obvious fix rule. Someone prod me if I forgot to do something ;-) > > > > > > The old version failed to compile with Sun's Forte tools on Solaris 10 > > > for Opteron (and you should've seen the code formatting!) > > > > What was the error? The style appears to be the same as the one Andrew > > used all across GDB when he mass-converted. > > > > (Yes, I think it's ugly.) The style has its benefits (but we should discuss that some other time if we feel like it, althouh I think we should use a consistent style). Hmm, maybe I just couldn't see the mistake. Oh well. Or there may have been a space after one of the backslashes; GCC handles this as a QoI extension. That was the exact problem. So I reverted David's patch (no offence meant) and remoced the trailing space. Mark Index: ChangeLog from Mark Kettenis * proc-api.c: Update copyright year. (_initialize_proc_api): Revert previous patch, removing spurious space instead. Index: proc-api.c =================================================================== RCS file: /cvs/src/src/gdb/proc-api.c,v retrieving revision 1.23 diff -u -p -r1.23 proc-api.c --- proc-api.c 9 Mar 2005 23:33:52 -0000 1.23 +++ proc-api.c 10 Mar 2005 09:08:27 -0000 @@ -1,6 +1,6 @@ /* Machine independent support for SVR4 /proc (process file system) for GDB. - Copyright 1999, 2000, 2001, 2003 Free Software Foundation, Inc. + Copyright 1999, 2000, 2001, 2003, 2005 Free Software Foundation, Inc. Written by Michael Snyder at Cygnus Solutions. Based on work by Fred Fish, Stu Grossman, Geoff Noer, and others. @@ -780,16 +780,16 @@ _initialize_proc_api (void) { struct cmd_list_element *c; - add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace, - _("Set tracing for /proc api calls."), - _("Show tracing for /proc api calls."), NULL, + add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace, _("\ +Set tracing for /proc api calls."), _("\ +Show tracing for /proc api calls."), NULL, set_procfs_trace_cmd, NULL, /* FIXME: i18n: */ &setlist, &showlist); - add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename, - _("Set filename for /proc tracefile."), - _("Show filename for /proc tracefile."), NULL, + add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename, _("\ +Set filename for /proc tracefile."), _("\ +Show filename for /proc tracefile."), NULL, set_procfs_file_cmd, NULL, /* FIXME: i18n: */ &setlist, &showlist);