Re: [COMMIT] Obvious - compilation failure in proc-api.c

[Mark Kettenis <kettenis@gnu.org>]

   Date: Wed, 9 Mar 2005 20:01:18 -0500
   From: Daniel Jacobowitz <drow@false.org>

   On Thu, Mar 10, 2005 at 12:09:36AM +0000, David Lecomber wrote:
   > On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote:
   > > On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote:
   > > > Dear all,
   > > > 
   > > > It's been a while since I committed something, but here's one for the
   > > > obvious fix rule.   Someone prod me if I forgot to do something ;-)  
   > > > 
   > > > The old version failed to compile with Sun's Forte tools on Solaris 10
   > > > for Opteron (and you should've seen the code formatting!) 
   > > 
   > > What was the error?  The style appears to be the same as the one Andrew
   > > used all across GDB when he mass-converted.
   > > 
   > > (Yes, I think it's ugly.)

The style has its benefits (but we should discuss that some other time
if we feel like it, althouh I think we should use a consistent style).

   Hmm, maybe I just couldn't see the mistake.  Oh well.  Or there may
   have been a space after one of the backslashes; GCC handles this as a
   QoI extension.

That was the exact problem.  So I reverted David's patch (no offence
meant) and remoced the trailing space.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* proc-api.c: Update copyright year.
	(_initialize_proc_api): Revert previous patch, removing spurious
	space instead.

Index: proc-api.c
===================================================================
RCS file: /cvs/src/src/gdb/proc-api.c,v
retrieving revision 1.23
diff -u -p -r1.23 proc-api.c
--- proc-api.c 9 Mar 2005 23:33:52 -0000 1.23
+++ proc-api.c 10 Mar 2005 09:08:27 -0000
@@ -1,6 +1,6 @@
 /* Machine independent support for SVR4 /proc (process file system) for GDB.
 
-   Copyright 1999, 2000, 2001, 2003 Free Software Foundation, Inc.
+   Copyright 1999, 2000, 2001, 2003, 2005 Free Software Foundation, Inc.
 
    Written by Michael Snyder at Cygnus Solutions.
    Based on work by Fred Fish, Stu Grossman, Geoff Noer, and others.
@@ -780,16 +780,16 @@ _initialize_proc_api (void)
 {
   struct cmd_list_element *c;
 
-  add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace,
-			   _("Set tracing for /proc api calls."),
-			   _("Show tracing for /proc api calls."), NULL,
+  add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace, _("\
+Set tracing for /proc api calls."), _("\
+Show tracing for /proc api calls."), NULL,
 			   set_procfs_trace_cmd,
 			   NULL, /* FIXME: i18n: */
 			   &setlist, &showlist);
 
-  add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename,
-			    _("Set filename for /proc tracefile."),
-			    _("Show filename for /proc tracefile."), NULL,
+  add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename, _("\
+Set filename for /proc tracefile."), _("\
+Show filename for /proc tracefile."), NULL,
 			    set_procfs_file_cmd,
 			    NULL, /* FIXME: i18n: */
 			    &setlist, &showlist);