From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26572 invoked by alias); 10 Mar 2005 01:01:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26478 invoked from network); 10 Mar 2005 01:01:29 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 10 Mar 2005 01:01:29 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D9C3C-0002B5-K9; Wed, 09 Mar 2005 20:01:18 -0500 Date: Thu, 10 Mar 2005 01:01:00 -0000 From: Daniel Jacobowitz To: David Lecomber Cc: patches Subject: Re: [COMMIT] Obvious - compilation failure in proc-api.c Message-ID: <20050310010118.GA8356@nevyn.them.org> Mail-Followup-To: David Lecomber , patches References: <1110411905.8084.34.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> <20050309234126.GA5799@nevyn.them.org> <1110413377.8084.40.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1110413377.8084.40.camel@cpc2-oxfd5-5-0-cust103.oxfd.cable.ntl.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00165.txt.bz2 On Thu, Mar 10, 2005 at 12:09:36AM +0000, David Lecomber wrote: > On Wed, 2005-03-09 at 18:41 -0500, Daniel Jacobowitz wrote: > > On Wed, Mar 09, 2005 at 11:45:05PM +0000, David Lecomber wrote: > > > Dear all, > > > > > > It's been a while since I committed something, but here's one for the > > > obvious fix rule. Someone prod me if I forgot to do something ;-) > > > > > > The old version failed to compile with Sun's Forte tools on Solaris 10 > > > for Opteron (and you should've seen the code formatting!) > > > > What was the error? The style appears to be the same as the one Andrew > > used all across GDB when he mass-converted. > > > > (Yes, I think it's ugly.) > > Well, it's only been that file that has complained, but the error was > pretty straight forward: > > /opt/SUNWspro/bin/cc -c -xtarget=opteron -xarch=amd64 -I. -I.././gdb > -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" > -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/.. > -I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl > -I.././gdb/../intl -DMI_OUT=1 proc-api.c > "proc-api.c", line 783: newline in string literal > "proc-api.c", line 786: syntax error before or at: set_procfs_trace_cmd > "proc-api.c", line 796: cannot recover from previous errors Hmm, maybe I just couldn't see the mistake. Oh well. Or there may have been a space after one of the backslashes; GCC handles this as a QoI extension. -- Daniel Jacobowitz CodeSourcery, LLC