From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@mvista.com>
Subject: Re: [RFA/c++] Fix printing classes with virtual base classes
Date: Tue, 13 Nov 2001 09:34:00 -0000 [thread overview]
Message-ID: <1011127022440.ZM10256@ocotillo.lan> (raw)
In-Reply-To: Daniel Jacobowitz <drow@mvista.com> "Re: [RFA/c++] Fix printing classes with virtual base classes" (Nov 26, 9:02pm)
On Nov 26, 9:02pm, Daniel Jacobowitz wrote:
> On Mon, Nov 26, 2001 at 08:19:45PM -0500, Daniel Jacobowitz wrote:
> > Whew. Finally tracked this down.
>
> [snip correct explanation]
>
> [snip incorrect patch]
>
> I find the use of VALUE_OFFSET and VALUE_EMBEDDED_OFFSET exceedingly
> unintuitive. Go figure. This one works a little bit better yet.
>
> --
> Daniel Jacobowitz Carnegie Mellon University
> MontaVista Software Debian GNU/Linux Developer
>
> 2001-11-26 Daniel Jacobowitz <drow@mvista.com>
>
> * gnu-v3-abi.c (gnuv3_rtti_type): Explicitly cast
> the vtable pointer to a pointer before loading it.
> (gnuv3_virtual_fn_field): Likewise.
I don't have any comments on Daniel's patch, but I am wondering who
will approve this. Given that we currently have no C++ maintainer,
should we treat Daniel's patch as an RFC and have him commit it after
a few days if there are no objections?
Kevin
WARNING: multiple messages have this Message-ID
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@mvista.com>
Subject: Re: [RFA/c++] Fix printing classes with virtual base classes
Date: Mon, 26 Nov 2001 18:25:00 -0000 [thread overview]
Message-ID: <1011127022440.ZM10256@ocotillo.lan> (raw)
Message-ID: <20011126182500.CALu0cX_9wPlx1REUUkS2s-RYz1TTYHdf6LMegXyOFE@z> (raw)
In-Reply-To: <20011126210231.A32203@nevyn.them.org>
On Nov 26, 9:02pm, Daniel Jacobowitz wrote:
> On Mon, Nov 26, 2001 at 08:19:45PM -0500, Daniel Jacobowitz wrote:
> > Whew. Finally tracked this down.
>
> [snip correct explanation]
>
> [snip incorrect patch]
>
> I find the use of VALUE_OFFSET and VALUE_EMBEDDED_OFFSET exceedingly
> unintuitive. Go figure. This one works a little bit better yet.
>
> --
> Daniel Jacobowitz Carnegie Mellon University
> MontaVista Software Debian GNU/Linux Developer
>
> 2001-11-26 Daniel Jacobowitz <drow@mvista.com>
>
> * gnu-v3-abi.c (gnuv3_rtti_type): Explicitly cast
> the vtable pointer to a pointer before loading it.
> (gnuv3_virtual_fn_field): Likewise.
I don't have any comments on Daniel's patch, but I am wondering who
will approve this. Given that we currently have no C++ maintainer,
should we treat Daniel's patch as an RFC and have him commit it after
a few days if there are no objections?
Kevin
next prev parent reply other threads:[~2001-11-27 2:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-13 9:24 Daniel Jacobowitz
2001-11-13 9:24 ` Daniel Jacobowitz
2001-11-13 9:34 ` Kevin Buettner [this message]
2001-11-26 18:25 ` Kevin Buettner
2001-11-26 21:07 ` Andrew Cagney
2001-11-13 21:56 ` Andrew Cagney
2001-11-14 22:09 ` Jim Blandy
2001-11-27 12:48 ` Jim Blandy
2001-11-26 18:02 ` Daniel Jacobowitz
2001-11-13 18:02 ` Jim Blandy
2001-11-14 9:33 ` Daniel Jacobowitz
2001-11-14 22:39 ` Jim Blandy
2001-11-14 22:41 ` Daniel Jacobowitz
2001-11-27 13:26 ` Daniel Jacobowitz
2001-11-21 13:03 ` Daniel Jacobowitz
2001-11-22 13:53 ` Jim Blandy
2001-11-30 11:42 ` Jim Blandy
2001-11-29 22:41 ` Daniel Jacobowitz
2001-11-30 8:48 ` Andrew Cagney
2001-11-21 17:30 ` Andrew Cagney
2001-11-30 8:57 ` Daniel Jacobowitz
2001-11-21 23:07 ` Daniel Jacobowitz
2001-11-27 13:16 ` Jim Blandy
2001-11-26 23:08 ` Daniel Jacobowitz
2001-11-26 20:38 ` Jim Blandy
2001-11-26 21:36 ` Daniel Jacobowitz
2001-11-14 0:12 ` Daniel Jacobowitz
2001-11-26 22:05 ` Daniel Berlin
2001-11-14 0:15 ` Daniel Berlin
2001-11-27 7:15 ` Jim Blandy
2001-11-14 13:02 ` Jim Blandy
2001-11-27 7:45 ` Daniel Jacobowitz
2001-11-14 13:55 ` Daniel Jacobowitz
2001-11-26 17:19 ` Daniel Jacobowitz
2001-11-15 14:06 Michael Elizabeth Chastain
2001-11-16 11:52 ` Daniel Berlin
2001-11-27 20:49 ` Daniel Berlin
2001-11-27 20:38 ` Michael Elizabeth Chastain
2001-11-30 9:00 Michael Elizabeth Chastain
2001-11-21 23:07 ` Michael Elizabeth Chastain
2001-11-22 3:17 ` Daniel Jacobowitz
2001-11-30 9:52 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011127022440.ZM10256@ocotillo.lan \
--to=kevinb@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox