From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Buettner To: gdb-patches@sources.redhat.com Cc: Daniel Jacobowitz Subject: Re: [RFA/c++] Fix printing classes with virtual base classes Date: Mon, 26 Nov 2001 18:25:00 -0000 Message-ID: <1011127022440.ZM10256@ocotillo.lan> References: <20011126201945.A27754@nevyn.them.org> <20011126210231.A32203@nevyn.them.org> X-SW-Source: 2001-11/msg00468.html Message-ID: <20011126182500.CALu0cX_9wPlx1REUUkS2s-RYz1TTYHdf6LMegXyOFE@z> On Nov 26, 9:02pm, Daniel Jacobowitz wrote: > On Mon, Nov 26, 2001 at 08:19:45PM -0500, Daniel Jacobowitz wrote: > > Whew. Finally tracked this down. > > [snip correct explanation] > > [snip incorrect patch] > > I find the use of VALUE_OFFSET and VALUE_EMBEDDED_OFFSET exceedingly > unintuitive. Go figure. This one works a little bit better yet. > > -- > Daniel Jacobowitz Carnegie Mellon University > MontaVista Software Debian GNU/Linux Developer > > 2001-11-26 Daniel Jacobowitz > > * gnu-v3-abi.c (gnuv3_rtti_type): Explicitly cast > the vtable pointer to a pointer before loading it. > (gnuv3_virtual_fn_field): Likewise. I don't have any comments on Daniel's patch, but I am wondering who will approve this. Given that we currently have no C++ maintainer, should we treat Daniel's patch as an RFC and have him commit it after a few days if there are no objections? Kevin