[RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate output

[RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate output

[Pierre Muller]

  Under cygwin there are failures in 
gdb.base/args.exp tests, but when I tried to 
understand those failure, I realized that
only the tests using single braces where
failing.
  But there are two series of tests,
the first using braces, the second using single quotes,
but they are resulting in the same lines in gdb.sum.
  This patch changes the output for the second 
series of test using single quotes.

OK to apply?
Pierre Muller
GDB pascal language support maintainer

PS: Using 
cat gdb.sum| sort | uniq -d

I found several other tests that have duplicate outputs,
are those kind of changes covered by the obvious rule?



gdb/testsuite/ChangeLog entry:

2008-02-27  Pierre Muller  <muller@ics.u-strasbg.fr>

	* gdb.base/args.exp: avoid same output for tests
	with single quotes.

Index: gdb/testsuite/gdb.base/args.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/args.exp,v
retrieving revision 1.12
diff -u -p -r1.12 args.exp
--- gdb/testsuite/gdb.base/args.exp     1 Jan 2008 22:53:18 -0000       1.12
+++ gdb/testsuite/gdb.base/args.exp     27 Feb 2008 09:44:22 -0000
@@ -94,9 +94,9 @@ args_test "two empty" {{1} {} {} 3}
 # Try with arguments containing literal single quotes.

 set GDBFLAGS "--args $binfile 1 '' 3"
-args_test "one empty" {{1} {''} {3}}
+args_test "one empty (with single quotes)" {{1} {''} {3}}

 set GDBFLAGS "--args $binfile 1 '' '' 3"
-args_test "two empty" {{1} {''} {''} {3}}
+args_test "two empty (with single quotes)" {{1} {''} {''} {3}}

 set GDBFLAGS $old_gdbflags

Re: [RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate output

[Daniel Jacobowitz]

On Wed, Feb 27, 2008 at 01:26:47PM +0100, Pierre Muller wrote:
> OK to apply?

Yes, thanks.

> I found several other tests that have duplicate outputs,
> are those kind of changes covered by the obvious rule?

I think so.

-- 
Daniel Jacobowitz
CodeSourcery

[Obvious] gdb/testsuite/i386-see.exp avoid duplicate output

[Pierre Muller]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
> Sent: Wednesday, February 27, 2008 2:20 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate
> output
> 
> On Wed, Feb 27, 2008 at 01:26:47PM +0100, Pierre Muller wrote:
> > OK to apply?
> 
> Yes, thanks.
Thanks, applied.
 
> > I found several other tests that have duplicate outputs,
> > are those kind of changes covered by the obvious rule?
> 
> I think so.

Thus I also committed this change as obvious:

gdb/testsuite/ChangeLog entry:
008-02-27  Pierre Muller  <muller@ics.u-strasbg.fr>

       * gdb.arch/i386-sse.exp: avoid same output for two breakpoint setting
       tests.

Index: gdb.arch/i386-sse.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v
retrieving revision 1.9
diff -u -p -r1.9 i386-sse.exp
--- gdb.arch/i386-sse.exp       1 Jan 2008 22:53:18 -0000       1.9
+++ gdb.arch/i386-sse.exp       27 Feb 2008 15:49:15 -0000
@@ -76,7 +76,7 @@ gdb_expect {

 gdb_test "break [gdb_get_line_number "first breakpoint here"]" \
          "Breakpoint .* at .*i386-sse.c.*" \
-         "set breakpoint in main"
+         "set first breakpoint in main"
 gdb_continue_to_breakpoint "continue to first breakpoint in main"

 foreach r {0 1 2 3 4 5 6 7} {
@@ -94,7 +94,7 @@ foreach r {0 1 2 3 4 5 6 7} {

 gdb_test "break [gdb_get_line_number "second breakpoint here"]" \
          "Breakpoint .* at .*i386-sse.c.*" \
-         "set breakpoint in main"
+         "set second breakpoint in main"
 gdb_continue_to_breakpoint "continue to second breakpoint in main"

 foreach r {0 1 2 3 4 5 6 7} {