From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8917 invoked by alias); 27 Feb 2008 12:27:15 -0000 Received: (qmail 8865 invoked by uid 22791); 27 Feb 2008 12:27:13 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 27 Feb 2008 12:26:51 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id D156318701A for ; Wed, 27 Feb 2008 13:32:46 +0100 (CET) From: "Pierre Muller" To: Subject: [RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate output Date: Wed, 27 Feb 2008 13:13:00 -0000 Message-ID: <000601c8793c$05388d10$0fa9a730$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00428.txt.bz2 Under cygwin there are failures in gdb.base/args.exp tests, but when I tried to understand those failure, I realized that only the tests using single braces where failing. But there are two series of tests, the first using braces, the second using single quotes, but they are resulting in the same lines in gdb.sum. This patch changes the output for the second series of test using single quotes. OK to apply? Pierre Muller GDB pascal language support maintainer PS: Using cat gdb.sum| sort | uniq -d I found several other tests that have duplicate outputs, are those kind of changes covered by the obvious rule? gdb/testsuite/ChangeLog entry: 2008-02-27 Pierre Muller * gdb.base/args.exp: avoid same output for tests with single quotes. Index: gdb/testsuite/gdb.base/args.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/args.exp,v retrieving revision 1.12 diff -u -p -r1.12 args.exp --- gdb/testsuite/gdb.base/args.exp 1 Jan 2008 22:53:18 -0000 1.12 +++ gdb/testsuite/gdb.base/args.exp 27 Feb 2008 09:44:22 -0000 @@ -94,9 +94,9 @@ args_test "two empty" {{1} {} {} 3} # Try with arguments containing literal single quotes. set GDBFLAGS "--args $binfile 1 '' 3" -args_test "one empty" {{1} {''} {3}} +args_test "one empty (with single quotes)" {{1} {''} {3}} set GDBFLAGS "--args $binfile 1 '' '' 3" -args_test "two empty" {{1} {''} {''} {3}} +args_test "two empty (with single quotes)" {{1} {''} {''} {3}} set GDBFLAGS $old_gdbflags