Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate output
Date: Wed, 27 Feb 2008 13:13:00 -0000	[thread overview]
Message-ID: <000601c8793c$05388d10$0fa9a730$@u-strasbg.fr> (raw)

  Under cygwin there are failures in 
gdb.base/args.exp tests, but when I tried to 
understand those failure, I realized that
only the tests using single braces where
failing.
  But there are two series of tests,
the first using braces, the second using single quotes,
but they are resulting in the same lines in gdb.sum.
  This patch changes the output for the second 
series of test using single quotes.

OK to apply?
Pierre Muller
GDB pascal language support maintainer

PS: Using 
cat gdb.sum| sort | uniq -d

I found several other tests that have duplicate outputs,
are those kind of changes covered by the obvious rule?



gdb/testsuite/ChangeLog entry:

2008-02-27  Pierre Muller  <muller@ics.u-strasbg.fr>

	* gdb.base/args.exp: avoid same output for tests
	with single quotes.

Index: gdb/testsuite/gdb.base/args.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/args.exp,v
retrieving revision 1.12
diff -u -p -r1.12 args.exp
--- gdb/testsuite/gdb.base/args.exp     1 Jan 2008 22:53:18 -0000       1.12
+++ gdb/testsuite/gdb.base/args.exp     27 Feb 2008 09:44:22 -0000
@@ -94,9 +94,9 @@ args_test "two empty" {{1} {} {} 3}
 # Try with arguments containing literal single quotes.

 set GDBFLAGS "--args $binfile 1 '' 3"
-args_test "one empty" {{1} {''} {3}}
+args_test "one empty (with single quotes)" {{1} {''} {3}}

 set GDBFLAGS "--args $binfile 1 '' '' 3"
-args_test "two empty" {{1} {''} {''} {3}}
+args_test "two empty (with single quotes)" {{1} {''} {''} {3}}

 set GDBFLAGS $old_gdbflags



             reply	other threads:[~2008-02-27 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 13:13 Pierre Muller [this message]
2008-02-27 15:12 ` Daniel Jacobowitz
2008-02-27 16:18   ` [Obvious] gdb/testsuite/i386-see.exp " Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000601c8793c$05388d10$0fa9a730$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox