From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Daniel Jacobowitz'" <drow@false.org>
Cc: <gdb-patches@sourceware.org>
Subject: [Obvious] gdb/testsuite/i386-see.exp avoid duplicate output
Date: Wed, 27 Feb 2008 16:18:00 -0000 [thread overview]
Message-ID: <000a01c87958$cde92230$69bb6690$@u-strasbg.fr> (raw)
In-Reply-To: <20080227132024.GD21538@caradoc.them.org>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
> Sent: Wednesday, February 27, 2008 2:20 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] gdb/testsuite/gdb.base/args.exp avoid duplicate
> output
>
> On Wed, Feb 27, 2008 at 01:26:47PM +0100, Pierre Muller wrote:
> > OK to apply?
>
> Yes, thanks.
Thanks, applied.
> > I found several other tests that have duplicate outputs,
> > are those kind of changes covered by the obvious rule?
>
> I think so.
Thus I also committed this change as obvious:
gdb/testsuite/ChangeLog entry:
008-02-27 Pierre Muller <muller@ics.u-strasbg.fr>
* gdb.arch/i386-sse.exp: avoid same output for two breakpoint setting
tests.
Index: gdb.arch/i386-sse.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v
retrieving revision 1.9
diff -u -p -r1.9 i386-sse.exp
--- gdb.arch/i386-sse.exp 1 Jan 2008 22:53:18 -0000 1.9
+++ gdb.arch/i386-sse.exp 27 Feb 2008 15:49:15 -0000
@@ -76,7 +76,7 @@ gdb_expect {
gdb_test "break [gdb_get_line_number "first breakpoint here"]" \
"Breakpoint .* at .*i386-sse.c.*" \
- "set breakpoint in main"
+ "set first breakpoint in main"
gdb_continue_to_breakpoint "continue to first breakpoint in main"
foreach r {0 1 2 3 4 5 6 7} {
@@ -94,7 +94,7 @@ foreach r {0 1 2 3 4 5 6 7} {
gdb_test "break [gdb_get_line_number "second breakpoint here"]" \
"Breakpoint .* at .*i386-sse.c.*" \
- "set breakpoint in main"
+ "set second breakpoint in main"
gdb_continue_to_breakpoint "continue to second breakpoint in main"
foreach r {0 1 2 3 4 5 6 7} {
prev parent reply other threads:[~2008-02-27 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 13:13 [RFA] gdb/testsuite/gdb.base/args.exp " Pierre Muller
2008-02-27 15:12 ` Daniel Jacobowitz
2008-02-27 16:18 ` Pierre Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01c87958$cde92230$69bb6690$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox