[PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Pierre Muller]

I committed the following patch that
transforms all obsolete gdb_ari.sh script
entries that had zero count into regression
entries.

  This allows to show more strongly any 
reuse of such obsolete function/macros.



Pierre Muller
Pascal language support maintainer for GDB



Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.84
diff -u -r1.84 gdb_ari.sh
--- gdb_ari.sh  14 Apr 2009 20:53:27 -0000      1.84
+++ gdb_ari.sh  14 Apr 2009 21:15:24 -0000
@@ -598,7 +598,7 @@

 BEGIN { doc["FETCH_INFERIOR_REGISTERS"] = "\
 Replace FETCH_INFERIOR_REGISTERS with inf-ptrace.c"
-    category["FETCH_INFERIOR_REGISTERS"] = ari_obsolete
+    category["FETCH_INFERIOR_REGISTERS"] = ari_regression
 }
 /(^|[^_[:alnum:]])FETCH_INFERIOR_REGISTERS([^_[:alnum:]]|$)/ {
     fail("FETCH_INFERIOR_REGISTERS")
@@ -606,7 +606,7 @@

 BEGIN { doc["CANNOT_FETCH_REGISTER"] = "\
 Replace CANNOT_FETCH_REGISTER with inf-ptrace.c"
-    category["CANNOT_FETCH_REGISTER"] = ari_obsolete
                                                     +
category["CANNOT_FETCH
_REGISTER"] = ari_regression
 }
 /(^|[^_[:alnum:]])CANNOT_FETCH_REGISTER([^_[:alnum:]]|$)/ {
     fail("CANNOT_FETCH_REGISTER")
@@ -614,7 +614,7 @@

 BEGIN { doc["CHILD_(|POST_)WAIT"] = "\
 Replace CHILD_WAIT and CHILD_POST_WAIT with inf-child.c"
-    category["CHILD_(|POST_)WAIT"] = ari_obsolete
+    category["CHILD_(|POST_)WAIT"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_(|POST_)WAIT([^_[:alnum:]]|$)/ {
     fail("CHILD_(|POST_)WAIT")
@@ -622,7 +622,7 @@

 BEGIN { doc["CHILD_POST_ATTACH"] = "\
 Replace CHILD_POST_ATTACH with inf-child.c"
-    category["CHILD_POST_ATTACH"] = ari_obsolete
+    category["CHILD_POST_ATTACH"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_POST_ATTACH([^_[:alnum:]]|$)/ {
     fail("CHILD_POST_ATTACH")
@@ -630,7 +630,7 @@

 BEGIN { doc["CHILD_THREAD_ALIVE"] = "\
 Replace CHILD_THREAD_ALIVE with inf-child.c"
-    category["CHILD_THREAD_ALIVE"] = ari_obsolete
+    category["CHILD_THREAD_ALIVE"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_THREAD_ALIVE([^_[:alnum:]]|$)/ {
     fail("CHILD_THREAD_ALIVE")
@@ -638,7 +638,7 @@

 BEGIN { doc["CHILD_PREPARE_TO_STORE"] = "\
 Replace CHILD_PREPARE_TO_STORE with inf-child.c"
-    category["CHILD_PREPARE_TO_STORE"] = ari_obsolete
                                                      +
category["CHILD_PREPA
RE_TO_STORE"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_PREPARE_TO_STORE([^_[:alnum:]]|$)/ {
     fail("CHILD_PREPARE_TO_STORE")
@@ -654,7 +654,7 @@

 BEGIN { doc["CHILD_ACKNOWLEDGE_CREATED_INFERIOR"] = "\
 Replace CHILD_ACKNOWLEDGE_CREATED_INFERIOR with inf-child.c"
-    category["CHILD_ACKNOWLEDGE_CREATED_INFERIOR"] = ari_obsolete
+    category["CHILD_ACKNOWLEDGE_CREATED_INFERIOR"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_ACKNOWLEDGE_CREATED_INFERIOR([^_[:alnum:]]|$)/ {
     fail("CHILD_ACKNOWLEDGE_CREATED_INFERIOR")
@@ -663,7 +663,7 @@
 BEGIN { doc["CHILD_(INSERT|REMOVE)_FORK_CATCHPOINT"] = "\
 Replace CHILD_INSERT_FORK_CATCHPOINT and CHILD_REMOVE_FORK_CATCHPOINT \
 with inf-child.c"
-    category["CHILD_(INSERT|REMOVE)_FORK_CATCHPOINT"] = ari_obsolete
+    category["CHILD_(INSERT|REMOVE)_FORK_CATCHPOINT"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_(INSERT|REMOVE)_FORK_CATCHPOINT([^_[:alnum:]]|$)/ {
     fail("CHILD_(INSERT|REMOVE)_FORK_CATCHPOINT")
@@ -672,7 +672,7 @@
 BEGIN { doc["CHILD_(INSERT|REMOVE)_VFORK_CATCHPOINT"] = "\
 Replace CHILD_INSERT_VFORK_CATCHPOINT and CHILD_REMOVE_VFORK_CATCHPOINT \
 with inf-child.c"
-    category["CHILD_(INSERT|REMOVE)_VFORK_CATCHPOINT"] = ari_obsolete
+    category["CHILD_(INSERT|REMOVE)_VFORK_CATCHPOINT"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_(INSERT|REMOVE)_VFORK_CATCHPOINT([^_[:alnum:]]|$)/
{
     fail("CHILD_(INSERT|REMOVE)_VFORK_CATCHPOINT")
@@ -680,7 +680,7 @@

 BEGIN { doc["CHILD_(INSERT|REMOVE)_EXEC_CATCHPOINT"] = "\
 Replace CHILD_(INSERT|REMOVE)_EXEC_CATCHPOINT with inf-child.c"
-    category["CHILD_(INSERT|REMOVE)_EXEC_CATCHPOINT"] = ari_obsolete
+    category["CHILD_(INSERT|REMOVE)_EXEC_CATCHPOINT"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_(INSERT|REMOVE)_EXEC_CATCHPOINT([^_[:alnum:]]|$)/ {
     fail("CHILD_(INSERT|REMOVE)_EXEC_CATCHPOINT")
@@ -688,7 +688,7 @@

 BEGIN { doc["CHILD_FOLLOW_FORK"] = "\
 Replace CHILD_FOLLOW_FORK with inf-child.c"
-    category["CHILD_FOLLOW_FORK"] = ari_obsolete
+    category["CHILD_FOLLOW_FORK"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_FOLLOW_FORK([^_[:alnum:]]|$)/ {
     fail("CHILD_FOLLOW_FORK")
@@ -696,7 +696,7 @@

 BEGIN { doc["CHILD_REPORTED_EXEC_EVENTS_PER_EXEC_CALL"] = "\
 Replace CHILD_REPORTED_EXEC_EVENTS_PER_EXEC_CALL with inf-child.c"
-    category["CHILD_REPORTED_EXEC_EVENTS_PER_EXEC_CALL"] = ari_obsolete
+    category["CHILD_REPORTED_EXEC_EVENTS_PER_EXEC_CALL"] = ari_regression
 }
 
/(^|[^_[:alnum:]])CHILD_REPORTED_EXEC_EVENTS_PER_EXEC_CALL([^_[:alnum:]]|$)/
{
     fail("CHILD_REPORTED_EXEC_EVENTS_PER_EXEC_CALL")
@@ -704,7 +704,7 @@

 BEGIN { doc["CHILD_HAS_EXITED"] = "\
 Replace CHILD_HAS_EXITED with inf-child.c"
-    category["CHILD_HAS_EXITED"] = ari_obsolete
+    category["CHILD_HAS_EXITED"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_HAS_EXITED([^_[:alnum:]]|$)/ {
     fail("CHILD_HAS_EXITED")
@@ -712,7 +712,7 @@

 BEGIN {
doc["CHILD_(ENABLE_EXCEPTION_CALLBACK|GET_CURRENT_EXCEPTION_EVENT)"] =
"\
 Replace CHILD_(ENABLE_EXCEPTION_CALLBACK|GET_CURRENT_EXCEPTION_EVENT) with
inf-
child.c"
-
category["CHILD_(ENABLE_EXCEPTION_CALLBACK|GET_CURRENT_EXCEPTION_EVENT)"] =
 ari_obsolete
+
category["CHILD_(ENABLE_EXCEPTION_CALLBACK|GET_CURRENT_EXCEPTION_EVENT)"] =
 ari_regression
 }
 
/(^|[^_[:alnum:]])CHILD_(ENABLE_EXCEPTION_CALLBACK|GET_CURRENT_EXCEPTION_EVE
NT)
([^_[:alnum:]]|$)/ {
     fail("CHILD_(ENABLE_EXCEPTION_CALLBACK|GET_CURRENT_EXCEPTION_EVENT)")
@@ -720,7 +720,7 @@

 BEGIN { doc["CHILD_PID_TO_(EXEC_FILE|STR)"] = "\
 Replace CHILD_PID_TO_(EXEC_FILE|STR) with inf-child.c"
-    category["CHILD_PID_TO_(EXEC_FILE|STR)"] = ari_obsolete
+    category["CHILD_PID_TO_(EXEC_FILE|STR)"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_PID_TO_(EXEC_FILE|STR)([^_[:alnum:]]|$)/ {
     fail("CHILD_PID_TO_(EXEC_FILE|STR)")
@@ -728,7 +728,7 @@

 BEGIN { doc["HAVE_OPTIONAL_PROC_FS"] = "\
 Replace HAVE_OPTIONAL_PROC_FS with inf-child.c"
-    category["HAVE_OPTIONAL_PROC_FS"] = ari_obsolete
+    category["HAVE_OPTIONAL_PROC_FS"] = ari_regression
 }
 /(^|[^_[:alnum:]])HAVE_OPTIONAL_PROC_FS([^_[:alnum:]]|$)/ {
     fail("HAVE_OPTIONAL_PROC_FS")
@@ -736,7 +736,7 @@

 BEGIN { doc["PROC_NAME_FMT"] = "\
 Replace PROC_NAME_FMT with inf-child.c"
-    category["PROC_NAME_FMT"] = ari_obsolete
+    category["PROC_NAME_FMT"] = ari_regression
 }
 /(^|[^_[:alnum:]])PROC_NAME_FMT([^_[:alnum:]]|$)/ {
     fail("PROC_NAME_FMT")
@@ -1069,7 +1069,7 @@

 BEGIN { doc["frame_unwind_unsigned_register"] = "\
 Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned"
-    category["frame_unwind_unsigned_register"] = ari_obsolete
+    category["frame_unwind_unsigned_register"] = ari_regression
 }
 /(^|[^_[:alnum:]])frame_unwind_unsigned_register([^_[:alnum:]]|$)/ {
     fail("frame_unwind_unsigned_register")
@@ -1096,7 +1096,7 @@

 BEGIN { doc["read_register"] = "\
 Replace read_register() with regcache_read() et.al."
-    category["read_register"] = ari_obsolete
+    category["read_register"] = ari_regression
 }
 /(^|[^_[:alnum:]])read_register([^_[:alnum:]]|$)/ {
     fail("read_register")
@@ -1505,7 +1505,7 @@

 BEGIN { doc["EXTRACT_RETURN_VALUE"] = "\
 Replace EXTRACT_RETURN_VALUE with RETURN_VALUE"
-    category["EXTRACT_RETURN_VALUE"] = ari_obsolete
+    category["EXTRACT_RETURN_VALUE"] = ari_regression
 }
 /(^|[^_[:alnum:]])EXTRACT_RETURN_VALUE([^_[:alnum:]]|$)/ {
     fail("EXTRACT_RETURN_VALUE")
@@ -1513,7 +1513,7 @@

 BEGIN { doc["STORE_RETURN_VALUE"] = "\
 Replace STORE_RETURN_VALUE with RETURN_VALUE"
-    category["STORE_RETURN_VALUE"] = ari_obsolete
+    category["STORE_RETURN_VALUE"] = ari_regression
 }
 /(^|[^_[:alnum:]])STORE_RETURN_VALUE([^_[:alnum:]]|$)/ {
     fail("STORE_RETURN_VALUE")
@@ -1522,7 +1522,7 @@
 BEGIN { doc["generic_use_struct_convention"] = "\
 Replace generic_use_struct_convention with nothing, \
 EXTRACT_STRUCT_VALUE_ADDRESS is a predicate"
-    category["generic_use_struct_convention"] = ari_obsolete
+    category["generic_use_struct_convention"] = ari_regression
 }
 /(^|[^_[:alnum:]])generic_use_struct_convention([^_[:alnum:]]|$)/ {
     fail("generic_use_struct_convention")

Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Joel Brobecker]

> I committed the following patch that transforms all obsolete
> gdb_ari.sh script entries that had zero count into regression entries.
> 
> This allows to show more strongly any reuse of such obsolete
> function/macros.

Errr, I'm having this most wonderful thoughts, right now. Since
these macros are no longer used, can't we just delete whatever
still left of them (including documentation), and then remove them
from the ARI? It's late and I'm tired, so I'm hoping I haven't
started dreaming yet :-).

-- 
Joel

RE: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Pierre Muller]

  I would tend to agree with you,
but it's just more work...
  So if anyone is volunteering, fine with me,
I doubt that I will have time to eradicate all
those unused macros from sources.

Pierre

PS: I also think that it would probably be good to
leave the unused functions/macros in at least one
GDB release, as people using GDB source code
might still be using such obsolete code,
especially if it was not deprecate'd.



> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : Wednesday, April 15, 2009 8:38 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression
> 
> > I committed the following patch that transforms all obsolete
> > gdb_ari.sh script entries that had zero count into regression
> entries.
> >
> > This allows to show more strongly any reuse of such obsolete
> > function/macros.
> 
> Errr, I'm having this most wonderful thoughts, right now. Since
> these macros are no longer used, can't we just delete whatever
> still left of them (including documentation), and then remove them
> from the ARI? It's late and I'm tired, so I'm hoping I haven't
> started dreaming yet :-).
> 
> --
> Joel

Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Ulrich Weigand]

Pierre Muller wrote:

>   I would tend to agree with you,
> but it's just more work...
>   So if anyone is volunteering, fine with me,
> I doubt that I will have time to eradicate all
> those unused macros from sources.
> 
> Pierre
> 
> PS: I also think that it would probably be good to
> leave the unused functions/macros in at least one
> GDB release, as people using GDB source code
> might still be using such obsolete code,
> especially if it was not deprecate'd.

It seems me the point of the ARI "regression" category
is to help catch adding back code patterns that we've
already managed to get rid of.  This makes perfect sense
for code patterns that *can* get added back accidentally
(e.g. coding style violations etc.).

However, some code patterns that are currently listed
as ARI regressions *cannot* be added back accidentally
anyway; for example, there is an ARI regression check
for use of the read_register function -- this function
is not even defined anywhere in the GDB source tree
today, so any attempt to call it would already cause
compile/link time failures.

I'd argue that ARI tests like those ought to be simply
deleted; they serve no further purpose.


B.t.w. as you're clearing up ARI results anyway (b.t.w.
thank you for your efforts in this area!), there's a
number of ARI tests where all remaining hits are in
fact false positives:

In the Obsolete category:

supply_register  (this function no longer exists; ARI
finds local struct members with the same name as false
positive results)

inside_entry_func  (this is now a static routine; the
original reason for this ARI entry no longer applies)

In the Deprecate category:

SP_REGNUM, PC_REGNUM, FP0_REGNUM   (these are not defined
anywhere any more; ARI finds local definitions with 
extended names like E_SP_REGNUM etc.)

In the Legacy category:

legacy_name  (this doesn't exist any more; ARI finds a
local variable with the same name)

I think these should also be simply deleted ...


Bye,
Ulrich


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Joel Brobecker]

> B.t.w. as you're clearing up ARI results anyway (b.t.w.
> thank you for your efforts in this area!), there's a
> number of ARI tests where all remaining hits are in
> fact false positives:
> 
> In the Obsolete category:
> 
> supply_register  (this function no longer exists; ARI
> finds local struct members with the same name as false
> positive results)
> 
> inside_entry_func  (this is now a static routine; the
> original reason for this ARI entry no longer applies)
> 
> In the Deprecate category:
> 
> SP_REGNUM, PC_REGNUM, FP0_REGNUM   (these are not defined
> anywhere any more; ARI finds local definitions with 
> extended names like E_SP_REGNUM etc.)
> 
> In the Legacy category:
> 
> legacy_name  (this doesn't exist any more; ARI finds a
> local variable with the same name)
> 
> I think these should also be simply deleted ...

Fully agreed. Nice catches, Ulrich :)

-- 
Joel

RE: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Pierre Muller]

> -----Message d'origine-----
> De : Joel Brobecker [mailto:brobecker@adacore.com]
> Envoyé : Thursday, April 16, 2009 9:17 AM
> À : Ulrich Weigand
> Cc : Pierre Muller; gdb-patches@sourceware.org
> Objet : Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression
> 
> > B.t.w. as you're clearing up ARI results anyway (b.t.w.
> > thank you for your efforts in this area!), there's a
> > number of ARI tests where all remaining hits are in
> > fact false positives:
> >
> > In the Obsolete category:
> >
> > supply_register  (this function no longer exists; ARI
> > finds local struct members with the same name as false
> > positive results)
> >
> > inside_entry_func  (this is now a static routine; the
> > original reason for this ARI entry no longer applies)

 I removed these two from gdb_ari.sh

> > In the Deprecate category:
> >
> > SP_REGNUM, PC_REGNUM, FP0_REGNUM   (these are not defined
> > anywhere any more; ARI finds local definitions with
> > extended names like E_SP_REGNUM etc.)

  OK, these three were DEPRECATED first anyhow...
I also removed those rules.

> > In the Legacy category:
> >
> > legacy_name  (this doesn't exist any more; ARI finds a
> > local variable with the same name)

  I looked at the code in remote.c,
and I am not sure that this is not what is meant by this rule:
there is no legacy_name in any ChangeLog, thus it is probably not 
a function.
 
It looks like this legacy argument in add_packet_config_cmd
add a "set/show remote" entry for
"binary-download-packet" as an alias of "X-packet".

I am wondering if this reminder is not that we should
remove that old "binary-download-packet" entry.
But then there is also still an entry for "binary-download in gdb.texinfo.



> > I think these should also be simply deleted ...
> 
> Fully agreed. Nice catches, Ulrich :)

  Thanks, Ulrich.


Pierre Muller
Pascal language support maintainer for GDB

Here is the change I committed.

Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.87
diff -r1.87 gdb_ari.sh
722,729d721
< BEGIN { doc["inside_entry_func"] = "\
< Replace inside_entry_func with nothing, or a call to
find_pc_partial_function"

<     category["inside_entry_func"] = ari_obsolete
< }
< /(^|[^_[:alnum:]])inside_entry_func([^_[:alnum:]]|$)/ {
<     fail("inside_entry_func")
< }
<
807,816d798
< BEGIN { doc["supply_register"] = "\
< Replace supply_register() with regcache_raw_supply; \
< note that eventually that method may, in turn, be replaced with \
< something parameterized with either a thread or target"
<     category["supply_register"] = ari_obsolete
< }
< /(^|[^_[:alnum:]])supply_register([^_[:alnum:]]|$)/ {
<     fail("supply_register")
< }
<
911,939d892
< # The totally dreaded FP REGNUM code.
<
< BEGIN { doc["SP_REGNUM"] = "\
< Replace SP_REGNUM with something indicating the frame inner-most address"
<     category["SP_REGNUM"] = ari_deprecate
< }
< /(^|[^_[:alnum:]])SP_REGNUM([^_[:alnum:]]|$)/ || \
< /(^|[^_[:alnum:]])set_gdbarch_sp_regnum([^_[:alnum:]]|$)/ {
<     fail("SP_REGNUM")
< }
<
< BEGIN { doc["FP0_REGNUM"] = "\
< Replace FP0_REGNUM with nothing, does not belong in generic code"
<     category["FP0_REGNUM"] = ari_deprecate
< }
< /(^|[^_[:alnum:]])FP0_REGNUM([^_[:alnum:]]|$)/ || \
< /(^|[^_[:alnum:]])set_gdbarch_fp0_regnum([^_[:alnum:]]|$)/ {
<     fail("FP0_REGNUM")
< }
<
< BEGIN { doc["PC_REGNUM"] = "\
< Replace PC_REGNUM with nothing, not needed"
<     category["PC_REGNUM"] = ari_deprecate
< }
< /(^|[^_[:alnum:]])PC_REGNUM([^_[:alnum:]]|$)/ || \
< /(^|[^_[:alnum:]])set_gdbarch_pc_regnum([^_[:alnum:]]|$)/ {
<     fail("PC_REGNUM")
< }
<

Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Ulrich Weigand]

Pierre Mueller wrote:

> > > In the Legacy category:
> > >
> > > legacy_name  (this doesn't exist any more; ARI finds a
> > > local variable with the same name)
> 
>   I looked at the code in remote.c,
> and I am not sure that this is not what is meant by this rule:
> there is no legacy_name in any ChangeLog, thus it is probably not=20
> a function.
>
> It looks like this legacy argument in add_packet_config_cmd
> add a "set/show remote" entry for
> "binary-download-packet" as an alias of "X-packet".
> 
> I am wondering if this reminder is not that we should
> remove that old "binary-download-packet" entry.
> But then there is also still an entry for "binary-download in gdb.texinfo.

Ah, right, the LEGACY category is fully auto-generated anyway;
every identifier named legacy_... will be picked up automatically.

I'm not sure that we even want to get rid of the packet command
aliases; in any case, it's probably not something that needs to
be tracked by ARI, so we might want to change the name of that
local variable.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

[Joel Brobecker]

> I would tend to agree with you,
> but it's just more work...

Not so much, as it turns out.  Out of all the various entities
that your patch highlighted, I got only 2 hits:
  - One is in a comment; I've sent an email to the maintainer
    hoping he'd have some time to take a look:
    http://www.sourceware.org/ml/gdb/2009-04/msg00133.html

  - One is in the documentation. I've sent a patch to remove it.
    http://www.sourceware.org/ml/gdb-patches/2009-04/msg00362.html

I think it's safe to remove all these entries from the ARI, now.
      
> PS: I also think that it would probably be good to leave the unused
> functions/macros in at least one GDB release, as people using GDB
> source code might still be using such obsolete code, especially if it
> was not deprecate'd.

There were deprecated and, as you have found out, are no longer
used, nor even setup.  Defining these macros would have had no
effect at all.

-- 
Joel