RE: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression

["Pierre Muller" <muller@ics.u-strasbg.fr>]

> -----Message d'origine-----
> De : Joel Brobecker [mailto:brobecker@adacore.com]
> Envoyé : Thursday, April 16, 2009 9:17 AM
> À : Ulrich Weigand
> Cc : Pierre Muller; gdb-patches@sourceware.org
> Objet : Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression
> 
> > B.t.w. as you're clearing up ARI results anyway (b.t.w.
> > thank you for your efforts in this area!), there's a
> > number of ARI tests where all remaining hits are in
> > fact false positives:
> >
> > In the Obsolete category:
> >
> > supply_register  (this function no longer exists; ARI
> > finds local struct members with the same name as false
> > positive results)
> >
> > inside_entry_func  (this is now a static routine; the
> > original reason for this ARI entry no longer applies)

 I removed these two from gdb_ari.sh

> > In the Deprecate category:
> >
> > SP_REGNUM, PC_REGNUM, FP0_REGNUM   (these are not defined
> > anywhere any more; ARI finds local definitions with
> > extended names like E_SP_REGNUM etc.)

  OK, these three were DEPRECATED first anyhow...
I also removed those rules.

> > In the Legacy category:
> >
> > legacy_name  (this doesn't exist any more; ARI finds a
> > local variable with the same name)

  I looked at the code in remote.c,
and I am not sure that this is not what is meant by this rule:
there is no legacy_name in any ChangeLog, thus it is probably not 
a function.
 
It looks like this legacy argument in add_packet_config_cmd
add a "set/show remote" entry for
"binary-download-packet" as an alias of "X-packet".

I am wondering if this reminder is not that we should
remove that old "binary-download-packet" entry.
But then there is also still an entry for "binary-download in gdb.texinfo.



> > I think these should also be simply deleted ...
> 
> Fully agreed. Nice catches, Ulrich :)

  Thanks, Ulrich.


Pierre Muller
Pascal language support maintainer for GDB

Here is the change I committed.

Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.87
diff -r1.87 gdb_ari.sh
722,729d721
< BEGIN { doc["inside_entry_func"] = "\
< Replace inside_entry_func with nothing, or a call to
find_pc_partial_function"

<     category["inside_entry_func"] = ari_obsolete
< }
< /(^|[^_[:alnum:]])inside_entry_func([^_[:alnum:]]|$)/ {
<     fail("inside_entry_func")
< }
<
807,816d798
< BEGIN { doc["supply_register"] = "\
< Replace supply_register() with regcache_raw_supply; \
< note that eventually that method may, in turn, be replaced with \
< something parameterized with either a thread or target"
<     category["supply_register"] = ari_obsolete
< }
< /(^|[^_[:alnum:]])supply_register([^_[:alnum:]]|$)/ {
<     fail("supply_register")
< }
<
911,939d892
< # The totally dreaded FP REGNUM code.
<
< BEGIN { doc["SP_REGNUM"] = "\
< Replace SP_REGNUM with something indicating the frame inner-most address"
<     category["SP_REGNUM"] = ari_deprecate
< }
< /(^|[^_[:alnum:]])SP_REGNUM([^_[:alnum:]]|$)/ || \
< /(^|[^_[:alnum:]])set_gdbarch_sp_regnum([^_[:alnum:]]|$)/ {
<     fail("SP_REGNUM")
< }
<
< BEGIN { doc["FP0_REGNUM"] = "\
< Replace FP0_REGNUM with nothing, does not belong in generic code"
<     category["FP0_REGNUM"] = ari_deprecate
< }
< /(^|[^_[:alnum:]])FP0_REGNUM([^_[:alnum:]]|$)/ || \
< /(^|[^_[:alnum:]])set_gdbarch_fp0_regnum([^_[:alnum:]]|$)/ {
<     fail("FP0_REGNUM")
< }
<
< BEGIN { doc["PC_REGNUM"] = "\
< Replace PC_REGNUM with nothing, not needed"
<     category["PC_REGNUM"] = ari_deprecate
< }
< /(^|[^_[:alnum:]])PC_REGNUM([^_[:alnum:]]|$)/ || \
< /(^|[^_[:alnum:]])set_gdbarch_pc_regnum([^_[:alnum:]]|$)/ {
<     fail("PC_REGNUM")
< }
<