From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30819 invoked by alias); 17 Apr 2009 11:23:02 -0000 Received: (qmail 30807 invoked by uid 22791); 17 Apr 2009 11:23:01 -0000 X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,HK_OBFDOMREQ,J_CHICKENPOX_37 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Apr 2009 11:22:56 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3HBLU05036236 ; Fri, 17 Apr 2009 13:21:30 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3HBLU5X050405 ; Fri, 17 Apr 2009 13:21:30 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3HBLT6D067214 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 17 Apr 2009 13:21:30 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Joel Brobecker'" , "'Ulrich Weigand'" Cc: References: <000401c9bd99$89bb01b0$9d310510$@u-strasbg.fr> <200904151352.n3FDqCcQ021342@d12av02.megacenter.de.ibm.com> <20090416071722.GF7585@adacore.com> In-Reply-To: <20090416071722.GF7585@adacore.com> Subject: RE: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression Date: Fri, 17 Apr 2009 11:23:00 -0000 Message-ID: <003c01c9bf4e$a95f28f0$fc1d7ad0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00423.txt.bz2 > -----Message d'origine----- > De=A0: Joel Brobecker [mailto:brobecker@adacore.com] > Envoy=E9=A0: Thursday, April 16, 2009 9:17 AM > =C0=A0: Ulrich Weigand > Cc=A0: Pierre Muller; gdb-patches@sourceware.org > Objet=A0: Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression >=20 > > B.t.w. as you're clearing up ARI results anyway (b.t.w. > > thank you for your efforts in this area!), there's a > > number of ARI tests where all remaining hits are in > > fact false positives: > > > > In the Obsolete category: > > > > supply_register (this function no longer exists; ARI > > finds local struct members with the same name as false > > positive results) > > > > inside_entry_func (this is now a static routine; the > > original reason for this ARI entry no longer applies) I removed these two from gdb_ari.sh > > In the Deprecate category: > > > > SP_REGNUM, PC_REGNUM, FP0_REGNUM (these are not defined > > anywhere any more; ARI finds local definitions with > > extended names like E_SP_REGNUM etc.) OK, these three were DEPRECATED first anyhow... I also removed those rules. > > In the Legacy category: > > > > legacy_name (this doesn't exist any more; ARI finds a > > local variable with the same name) I looked at the code in remote.c, and I am not sure that this is not what is meant by this rule: there is no legacy_name in any ChangeLog, thus it is probably not=20 a function. =20 It looks like this legacy argument in add_packet_config_cmd add a "set/show remote" entry for "binary-download-packet" as an alias of "X-packet". I am wondering if this reminder is not that we should remove that old "binary-download-packet" entry. But then there is also still an entry for "binary-download in gdb.texinfo. > > I think these should also be simply deleted ... >=20 > Fully agreed. Nice catches, Ulrich :) Thanks, Ulrich. Pierre Muller Pascal language support maintainer for GDB Here is the change I committed. Index: gdb_ari.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.87 diff -r1.87 gdb_ari.sh 722,729d721 < BEGIN { doc["inside_entry_func"] =3D "\ < Replace inside_entry_func with nothing, or a call to find_pc_partial_function" < category["inside_entry_func"] =3D ari_obsolete < } < /(^|[^_[:alnum:]])inside_entry_func([^_[:alnum:]]|$)/ { < fail("inside_entry_func") < } < 807,816d798 < BEGIN { doc["supply_register"] =3D "\ < Replace supply_register() with regcache_raw_supply; \ < note that eventually that method may, in turn, be replaced with \ < something parameterized with either a thread or target" < category["supply_register"] =3D ari_obsolete < } < /(^|[^_[:alnum:]])supply_register([^_[:alnum:]]|$)/ { < fail("supply_register") < } < 911,939d892 < # The totally dreaded FP REGNUM code. < < BEGIN { doc["SP_REGNUM"] =3D "\ < Replace SP_REGNUM with something indicating the frame inner-most address" < category["SP_REGNUM"] =3D ari_deprecate < } < /(^|[^_[:alnum:]])SP_REGNUM([^_[:alnum:]]|$)/ || \ < /(^|[^_[:alnum:]])set_gdbarch_sp_regnum([^_[:alnum:]]|$)/ { < fail("SP_REGNUM") < } < < BEGIN { doc["FP0_REGNUM"] =3D "\ < Replace FP0_REGNUM with nothing, does not belong in generic code" < category["FP0_REGNUM"] =3D ari_deprecate < } < /(^|[^_[:alnum:]])FP0_REGNUM([^_[:alnum:]]|$)/ || \ < /(^|[^_[:alnum:]])set_gdbarch_fp0_regnum([^_[:alnum:]]|$)/ { < fail("FP0_REGNUM") < } < < BEGIN { doc["PC_REGNUM"] =3D "\ < Replace PC_REGNUM with nothing, not needed" < category["PC_REGNUM"] =3D ari_deprecate < } < /(^|[^_[:alnum:]])PC_REGNUM([^_[:alnum:]]|$)/ || \ < /(^|[^_[:alnum:]])set_gdbarch_pc_regnum([^_[:alnum:]]|$)/ { < fail("PC_REGNUM") < } <