From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2198 invoked by alias); 15 Apr 2009 13:52:24 -0000 Received: (qmail 2186 invoked by uid 22791); 15 Apr 2009 13:52:23 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Apr 2009 13:52:17 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.14.3/8.13.8) with ESMTP id n3FDqEB9562416 for ; Wed, 15 Apr 2009 13:52:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3FDqEWa4108426 for ; Wed, 15 Apr 2009 15:52:14 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3FDqDTv021356 for ; Wed, 15 Apr 2009 15:52:13 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n3FDqCcQ021342; Wed, 15 Apr 2009 15:52:12 +0200 Message-Id: <200904151352.n3FDqCcQ021342@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 15 Apr 2009 15:52:12 +0200 Subject: Re: [PATCH] gdbadmin/ss/gdb_ari.sh obsolete->regression To: muller@ics.u-strasbg.fr (Pierre Muller) Date: Wed, 15 Apr 2009 13:52:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com ('Joel Brobecker'), gdb-patches@sourceware.org In-Reply-To: <000401c9bd99$89bb01b0$9d310510$@u-strasbg.fr> from "Pierre Muller" at Apr 15, 2009 09:12:29 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00301.txt.bz2 Pierre Muller wrote: > I would tend to agree with you, > but it's just more work... > So if anyone is volunteering, fine with me, > I doubt that I will have time to eradicate all > those unused macros from sources. > > Pierre > > PS: I also think that it would probably be good to > leave the unused functions/macros in at least one > GDB release, as people using GDB source code > might still be using such obsolete code, > especially if it was not deprecate'd. It seems me the point of the ARI "regression" category is to help catch adding back code patterns that we've already managed to get rid of. This makes perfect sense for code patterns that *can* get added back accidentally (e.g. coding style violations etc.). However, some code patterns that are currently listed as ARI regressions *cannot* be added back accidentally anyway; for example, there is an ARI regression check for use of the read_register function -- this function is not even defined anywhere in the GDB source tree today, so any attempt to call it would already cause compile/link time failures. I'd argue that ARI tests like those ought to be simply deleted; they serve no further purpose. B.t.w. as you're clearing up ARI results anyway (b.t.w. thank you for your efforts in this area!), there's a number of ARI tests where all remaining hits are in fact false positives: In the Obsolete category: supply_register (this function no longer exists; ARI finds local struct members with the same name as false positive results) inside_entry_func (this is now a static routine; the original reason for this ARI entry no longer applies) In the Deprecate category: SP_REGNUM, PC_REGNUM, FP0_REGNUM (these are not defined anywhere any more; ARI finds local definitions with extended names like E_SP_REGNUM etc.) In the Legacy category: legacy_name (this doesn't exist any more; ARI finds a local variable with the same name) I think these should also be simply deleted ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com