Re: mi/2549: data-list-register-values igonores the format parameter

Re: mi/2549: data-list-register-values igonores the format parameter

[Nick Roberts]

 > I have the following trace from a debug session:
 > 
 > 226,777 52-data-list-register-values --thread 1 d 3
 > 226,778 53-data-list-register-values --thread 1 t 3
 > 226,778 54-data-list-register-values --thread 1 N 3
 > 226,779 55-data-list-register-values --thread 1 o 3 0 1 2 4 5 6
 > 226,781 52^done,register-values=[{number="3",value="-1209315340"}]
 > 226,781 (gdb) 
 > 226,782 53^done,register-values=[{number="3",value="-1209315340"}]
 > 226,782 (gdb) 
 > 226,782 54^done,register-values=[{number="3",value="-1209315340"}]
 > 226,782 (gdb) 
 > 226,783 55^done,register-values=[{number="3",value="-1209315340"},{number="0",value="-1073743420"},{number="1",value="-1073743552"},{number="2",value="1"},{number="4",value="0xbffff920"},{number="5",value="0xbffff928"},{number="6",value="-1207956256"}]
 > 226,783 (gdb) 

FWIW I can see this regression too.  I think it's due to this change:


    2008-10-28  Tom Tromey  <tromey@redhat.com>

            ...
   	    (val_print): Remove format, deref_ref, pretty arguments; add
	    options.  Update.
            ...


The test mi2-regs.exp only tests this command on Solaris, so running the
testsuite on any other architecture wouldn't reveal the problem.

I've cc'ed the GDB mailing list rather than GNATS as it's a recent change and
this list seems to get more attention.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: mi/2549: data-list-register-values igonores the format parameter

[Tom Tromey]

>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:

Nick> FWIW I can see this regression too.  I think it's due to this change:
[...]

Please try this patch.

I am sending it through regression testing.

Tom

2008-11-10  Tom Tromey  <tromey@redhat.com>

	* mi/mi-main.c (get_register): Use get_formatted_print_options.

diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index a9fbcad..4554008 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -501,7 +501,7 @@ get_register (int regnum, int format)
   else
     {
       struct value_print_options opts;
-      get_user_print_options (&opts);
+      get_formatted_print_options (&opts, format);
       opts.deref_ref = 1;
       val_print (register_type (current_gdbarch, regnum), buffer, 0, 0,
 		 stb->stream, 0, &opts, current_language);

Re: mi/2549: data-list-register-values igonores the format parameter

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> I am sending it through regression testing.

FYI, it passed there.  Not super surprising, but still good to know.

Tom

Re: mi/2549: data-list-register-values igonores the format parameter

[Nick Roberts]

Tom Tromey writes:
 > >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
 > 
 > Tom> I am sending it through regression testing.
 > 
 > FYI, it passed there.  Not super surprising, but still good to know.

I agree.  It's not that surprising as your change is in get_registers which
only gets called by mi_cmd_data_list_register_values and, as I said earlier,
there are currently no tests for -data-list-register-values except on sparc.

Why not add the tests below?  There were three failures before your change and
they all pass after it.  They're pretty basic, and I don't know if there are
any architectures for which they wouldn't work, but they would at least prevent
this regression from occurring again.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


# Copyright 2008 Free Software Foundation, Inc.

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

# Test essential Machine interface (MI) operations
#
# Verify that, using the MI, we can run a simple program and look at registers.
#
# The goal is not to test gdb functionality, which is done by other tests,
# but to verify the correct output response to MI operations.
#


load_lib mi-support.exp
set MIFLAGS "-i=mi"

gdb_exit
if [mi_gdb_start] {
    continue
}

set testfile "basics"
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}
if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
     untested mi-regs.exp
     return -1
}

proc register_tests_no_exec { } {
	# Test the generic IDT chip.
	mi_gdb_test "111-data-list-register-values" \
		".*111\\^error,msg=\"mi_cmd_data_list_register_values: Usage: -data-list-register-values <format> \\\[<regnum1>...<regnumN>\\\]\"" \
		"wrong arguments"

	mi_gdb_test "111-data-list-register-values x" \
		".*111\\^error,msg=\"No registers\.\"" \
		"no executable"
}

proc register_tests { } {
    global hex
    global decimal
    set octal "\[0-7\]+"
    set binary "\[0-1\]+"
    set float "\\-?((\[0-9\]+(\\.\[0-9\]+)?(e\[-+\]\[0-9\]+)?)|(nan\\($hex\\)))"

    mi_gdb_test "222-data-list-register-values x" \
	    "222\\^done,register-values=\\\[\{number=\"0\",value=\"$hex\"\}.*\\\]" \
	    "register values x"

    mi_gdb_test "333-data-list-register-values f" \
	    "333\\^done,register-values=\\\[\{number=\"0\",value=\"$float\"\}.*\\\]" \
	    "register values f"

    mi_gdb_test "444-data-list-register-values d" \
	    "444\\^done,register-values=\\\[\{number=\"0\",value=\"-?$decimal\"\}.*\\\]" \
	    "register values d"

    mi_gdb_test "555-data-list-register-values o" \
	    "555\\^done,register-values=\\\[\{number=\"0\",value=\"$octal\"\}.*\\\]" \
	    "register values o"

    mi_gdb_test "666-data-list-register-values t" \
	    "666\\^done,register-values=\\\[\{number=\"0\",value=\"$binary\"\}.*\\\]" \
	    "register values t"
}

register_tests_no_exec
mi_run_to_main
register_tests

mi_gdb_exit
return 0