From: Tom Tromey <tromey@redhat.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: pawel.piech@windriver.com, gdb@sourceware.org
Subject: Re: mi/2549: data-list-register-values igonores the format parameter
Date: Tue, 11 Nov 2008 00:53:00 -0000 [thread overview]
Message-ID: <m3ej1jhynu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <18711.59624.46811.903567@kahikatea.snap.net.nz> (Nick Roberts's message of "Mon\, 10 Nov 2008 20\:55\:20 +1300")
>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
Nick> FWIW I can see this regression too. I think it's due to this change:
[...]
Please try this patch.
I am sending it through regression testing.
Tom
2008-11-10 Tom Tromey <tromey@redhat.com>
* mi/mi-main.c (get_register): Use get_formatted_print_options.
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index a9fbcad..4554008 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -501,7 +501,7 @@ get_register (int regnum, int format)
else
{
struct value_print_options opts;
- get_user_print_options (&opts);
+ get_formatted_print_options (&opts, format);
opts.deref_ref = 1;
val_print (register_type (current_gdbarch, regnum), buffer, 0, 0,
stb->stream, 0, &opts, current_language);
next prev parent reply other threads:[~2008-11-11 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081107201949.23460.qmail@sourceware.org>
2008-11-10 8:22 ` Nick Roberts
2008-11-11 0:53 ` Tom Tromey [this message]
2008-11-11 2:11 ` Tom Tromey
2008-11-11 8:51 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ej1jhynu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb@sourceware.org \
--cc=nickrob@snap.net.nz \
--cc=pawel.piech@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox