From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-33310-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 20261 invoked by alias); 11 Nov 2008 00:53:12 -0000
Received: (qmail 20229 invoked by uid 22791); 11 Nov 2008 00:53:10 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Nov 2008 00:52:34 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAB0qSbR001742; 	Mon, 10 Nov 2008 19:52:29 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAB0qPQc004736; 	Mon, 10 Nov 2008 19:52:27 -0500
Received: from opsy.redhat.com (vpn-13-202.rdu.redhat.com [10.11.13.202]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAB0qMdE026849; 	Mon, 10 Nov 2008 19:52:23 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id DF1A63786D6; Mon, 10 Nov 2008 17:52:21 -0700 (MST)
To: Nick Roberts <nickrob@snap.net.nz>
Cc: pawel.piech@windriver.com, gdb@sourceware.org
Subject: Re: mi/2549: data-list-register-values igonores the format parameter
References: <20081107201949.23460.qmail@sourceware.org> 	<18711.59624.46811.903567@kahikatea.snap.net.nz>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
X-Attribution:  Tom
Date: Tue, 11 Nov 2008 00:53:00 -0000
In-Reply-To: <18711.59624.46811.903567@kahikatea.snap.net.nz> (Nick Roberts's message of "Mon\, 10 Nov 2008 20\:55\:20 +1300")
Message-ID: <m3ej1jhynu.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00075.txt.bz2

>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:

Nick> FWIW I can see this regression too.  I think it's due to this change:
[...]

Please try this patch.

I am sending it through regression testing.

Tom

2008-11-10  Tom Tromey  <tromey@redhat.com>

	* mi/mi-main.c (get_register): Use get_formatted_print_options.

diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index a9fbcad..4554008 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -501,7 +501,7 @@ get_register (int regnum, int format)
   else
     {
       struct value_print_options opts;
-      get_user_print_options (&opts);
+      get_formatted_print_options (&opts, format);
       opts.deref_ref = 1;
       val_print (register_type (current_gdbarch, regnum), buffer, 0, 0,
 		 stb->stream, 0, &opts, current_language);