From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20970 invoked by alias); 11 Nov 2008 08:51:30 -0000 Received: (qmail 20856 invoked by uid 22791); 11 Nov 2008 08:51:29 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Nov 2008 08:50:20 +0000 Received: from kahikatea.snap.net.nz (unknown [123.255.29.101]) by viper.snap.net.nz (Postfix) with ESMTP id 1477F3DA94B; Tue, 11 Nov 2008 21:50:17 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 5640A8FC6D; Tue, 11 Nov 2008 21:50:14 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18713.18244.632968.822897@kahikatea.snap.net.nz> Date: Tue, 11 Nov 2008 08:51:00 -0000 To: tromey@redhat.com Cc: pawel.piech@windriver.com, gdb@sourceware.org Subject: Re: mi/2549: data-list-register-values igonores the format parameter In-Reply-To: References: <20081107201949.23460.qmail@sourceware.org> <18711.59624.46811.903567@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.3.1 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00077.txt.bz2 Tom Tromey writes: > >>>>> "Tom" == Tom Tromey writes: > > Tom> I am sending it through regression testing. > > FYI, it passed there. Not super surprising, but still good to know. I agree. It's not that surprising as your change is in get_registers which only gets called by mi_cmd_data_list_register_values and, as I said earlier, there are currently no tests for -data-list-register-values except on sparc. Why not add the tests below? There were three failures before your change and they all pass after it. They're pretty basic, and I don't know if there are any architectures for which they wouldn't work, but they would at least prevent this regression from occurring again. -- Nick http://www.inet.net.nz/~nickrob # Copyright 2008 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 3 of the License, or # (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program. If not, see . # Test essential Machine interface (MI) operations # # Verify that, using the MI, we can run a simple program and look at registers. # # The goal is not to test gdb functionality, which is done by other tests, # but to verify the correct output response to MI operations. # load_lib mi-support.exp set MIFLAGS "-i=mi" gdb_exit if [mi_gdb_start] { continue } set testfile "basics" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } { untested mi-regs.exp return -1 } proc register_tests_no_exec { } { # Test the generic IDT chip. mi_gdb_test "111-data-list-register-values" \ ".*111\\^error,msg=\"mi_cmd_data_list_register_values: Usage: -data-list-register-values \\\[...\\\]\"" \ "wrong arguments" mi_gdb_test "111-data-list-register-values x" \ ".*111\\^error,msg=\"No registers\.\"" \ "no executable" } proc register_tests { } { global hex global decimal set octal "\[0-7\]+" set binary "\[0-1\]+" set float "\\-?((\[0-9\]+(\\.\[0-9\]+)?(e\[-+\]\[0-9\]+)?)|(nan\\($hex\\)))" mi_gdb_test "222-data-list-register-values x" \ "222\\^done,register-values=\\\[\{number=\"0\",value=\"$hex\"\}.*\\\]" \ "register values x" mi_gdb_test "333-data-list-register-values f" \ "333\\^done,register-values=\\\[\{number=\"0\",value=\"$float\"\}.*\\\]" \ "register values f" mi_gdb_test "444-data-list-register-values d" \ "444\\^done,register-values=\\\[\{number=\"0\",value=\"-?$decimal\"\}.*\\\]" \ "register values d" mi_gdb_test "555-data-list-register-values o" \ "555\\^done,register-values=\\\[\{number=\"0\",value=\"$octal\"\}.*\\\]" \ "register values o" mi_gdb_test "666-data-list-register-values t" \ "666\\^done,register-values=\\\[\{number=\"0\",value=\"$binary\"\}.*\\\]" \ "register values t" } register_tests_no_exec mi_run_to_main register_tests mi_gdb_exit return 0