odd (inappropriate?) sparc references in sim

odd (inappropriate?) sparc references in sim

[Joel Sherrill]

Hi,

I did a grep for sparc and got some hits that
might indicate cut and paste issues:

./sh64/sh-desc.c:  /* FIXME: for the sparc case we can determine 
insn-endianness statically.
./sh64/sim-if.c:  /* Store in a global so things like sparc32_dump_regs 
can be invoked
./cris/cris-desc.c:  /* FIXME: for the sparc case we can determine 
insn-endianness statically.
./frv/frv.c:     otherwise it may result in 0x7fffffff (sparc 
compatibility) or
./frv/sim-if.c:  /* Store in a global so things like sparc32_dump_regs 
can be invoked
./m32r/sim-if.c:  /* Store in a global so things like sparc32_dump_regs 
can be invoked
./iq2000/sim-if.c:  /* Store in a global so things like 
sparc32_dump_regs can be invoked

I am not sure about the endianness comment but the
sparc32_dump_regs one looks incorrect.

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
   Support Available             (256) 722-9985

Re: odd (inappropriate?) sparc references in sim

[Dave Korn]

Joel Sherrill wrote:

> ./m32r/sim-if.c:  /* Store in a global so things like sparc32_dump_regs
> can be invoked
> ./iq2000/sim-if.c:  /* Store in a global so things like
> sparc32_dump_regs can be invoked
> 
> I am not sure about the endianness comment but the
> sparc32_dump_regs one looks incorrect.

  Well, dunno what sparc32_dump_regs is or ever was, but the important
property it must have had that made this comment want to refer to it is that
it needed a a static pointer to the current SIM_DESC because it didn't get one
passed in as an argument.

  It appears that frv/mloop.in and a private port I'm developing are the only
actual users of this static.  Unless I've misread the code (possible since I'm
only grepping it without context) every other use is just to set its current
value, in either startup or main loop code.

    cheers,
      DaveK

Re: odd (inappropriate?) sparc references in sim

[Joel Sherrill]

Dave Korn wrote:
> Joel Sherrill wrote:
>
>   
>> ./m32r/sim-if.c:  /* Store in a global so things like sparc32_dump_regs
>> can be invoked
>> ./iq2000/sim-if.c:  /* Store in a global so things like
>> sparc32_dump_regs can be invoked
>>
>> I am not sure about the endianness comment but the
>> sparc32_dump_regs one looks incorrect.
>>     
>
>   Well, dunno what sparc32_dump_regs is or ever was, but the important
> property it must have had that made this comment want to refer to it is that
> it needed a a static pointer to the current SIM_DESC because it didn't get one
> passed in as an argument.
>
>   It appears that frv/mloop.in and a private port I'm developing are the only
> actual users of this static.  Unless I've misread the code (possible since I'm
> only grepping it without context) every other use is just to set its current
> value, in either startup or main loop code.
>
>   
I will leave it to you to decide if this comment should be changed/improved.

I just found it odd. :)

--joel
>     cheers,
>       DaveK
>
>
>   


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
   Support Available             (256) 722-9985