Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Dave Korn <dave.korn.cygwin@googlemail.com>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: gdb@sourceware.org
Subject: Re: odd (inappropriate?) sparc references in sim
Date: Thu, 15 Oct 2009 14:53:00 -0000	[thread overview]
Message-ID: <4AD73A25.8090102@gmail.com> (raw)
In-Reply-To: <4AD7233C.3010005@oarcorp.com>

Joel Sherrill wrote:

> ./m32r/sim-if.c:  /* Store in a global so things like sparc32_dump_regs
> can be invoked
> ./iq2000/sim-if.c:  /* Store in a global so things like
> sparc32_dump_regs can be invoked
> 
> I am not sure about the endianness comment but the
> sparc32_dump_regs one looks incorrect.

  Well, dunno what sparc32_dump_regs is or ever was, but the important
property it must have had that made this comment want to refer to it is that
it needed a a static pointer to the current SIM_DESC because it didn't get one
passed in as an argument.

  It appears that frv/mloop.in and a private port I'm developing are the only
actual users of this static.  Unless I've misread the code (possible since I'm
only grepping it without context) every other use is just to set its current
value, in either startup or main loop code.

    cheers,
      DaveK



  reply	other threads:[~2009-10-15 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 13:31 Joel Sherrill
2009-10-15 14:53 ` Dave Korn [this message]
2009-10-15 15:23   ` Joel Sherrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD73A25.8090102@gmail.com \
    --to=dave.korn.cygwin@googlemail.com \
    --cc=gdb@sourceware.org \
    --cc=joel.sherrill@oarcorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox