Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Sherrill <joel.sherrill@oarcorp.com>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: odd (inappropriate?) sparc references in sim
Date: Thu, 15 Oct 2009 15:23:00 -0000	[thread overview]
Message-ID: <4AD73773.3020508@oarcorp.com> (raw)
In-Reply-To: <4AD73A25.8090102@gmail.com>

Dave Korn wrote:
> Joel Sherrill wrote:
>
>   
>> ./m32r/sim-if.c:  /* Store in a global so things like sparc32_dump_regs
>> can be invoked
>> ./iq2000/sim-if.c:  /* Store in a global so things like
>> sparc32_dump_regs can be invoked
>>
>> I am not sure about the endianness comment but the
>> sparc32_dump_regs one looks incorrect.
>>     
>
>   Well, dunno what sparc32_dump_regs is or ever was, but the important
> property it must have had that made this comment want to refer to it is that
> it needed a a static pointer to the current SIM_DESC because it didn't get one
> passed in as an argument.
>
>   It appears that frv/mloop.in and a private port I'm developing are the only
> actual users of this static.  Unless I've misread the code (possible since I'm
> only grepping it without context) every other use is just to set its current
> value, in either startup or main loop code.
>
>   
I will leave it to you to decide if this comment should be changed/improved.

I just found it odd. :)

--joel
>     cheers,
>       DaveK
>
>
>   


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
   Support Available             (256) 722-9985



      reply	other threads:[~2009-10-15 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 13:31 Joel Sherrill
2009-10-15 14:53 ` Dave Korn
2009-10-15 15:23   ` Joel Sherrill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD73773.3020508@oarcorp.com \
    --to=joel.sherrill@oarcorp.com \
    --cc=dave.korn.cygwin@googlemail.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox