From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28438 invoked by alias); 15 Oct 2009 14:53:53 -0000 Received: (qmail 28425 invoked by uid 22791); 15 Oct 2009 14:53:51 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Oct 2009 14:53:43 +0000 Received: from iceland.oarcorp.com (192.168.1.154) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.1.393.1; Thu, 15 Oct 2009 09:53:41 -0500 Message-ID: <4AD73773.3020508@oarcorp.com> Date: Thu, 15 Oct 2009 15:23:00 -0000 From: Joel Sherrill User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Dave Korn CC: "gdb@sourceware.org" Subject: Re: odd (inappropriate?) sparc references in sim References: <4AD7233C.3010005@oarcorp.com> <4AD73A25.8090102@gmail.com> In-Reply-To: <4AD73A25.8090102@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00270.txt.bz2 Dave Korn wrote: > Joel Sherrill wrote: > > >> ./m32r/sim-if.c: /* Store in a global so things like sparc32_dump_regs >> can be invoked >> ./iq2000/sim-if.c: /* Store in a global so things like >> sparc32_dump_regs can be invoked >> >> I am not sure about the endianness comment but the >> sparc32_dump_regs one looks incorrect. >> > > Well, dunno what sparc32_dump_regs is or ever was, but the important > property it must have had that made this comment want to refer to it is that > it needed a a static pointer to the current SIM_DESC because it didn't get one > passed in as an argument. > > It appears that frv/mloop.in and a private port I'm developing are the only > actual users of this static. Unless I've misread the code (possible since I'm > only grepping it without context) every other use is just to set its current > value, in either startup or main loop code. > > I will leave it to you to decide if this comment should be changed/improved. I just found it odd. :) --joel > cheers, > DaveK > > > -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985