Re: GDB 5.1.92 available

Re: GDB 5.1.92 available

[Michael Elizabeth Chastain]

The last-minute x86-64 warning has a typo in it:

  printf_filtered
   ("NOTE: This function doesn't seem to have a valid prologue.\n"
    "      Try to add -fno-omit-frame-pointer tou your gcc's CFLAGS.\n");
                                              ^^^

Michael C

Re: GDB 5.1.92 available [patch]

[Michal Ludvig]

Michael Elizabeth Chastain wrote:
> The last-minute x86-64 warning has a typo in it:
> 
>   printf_filtered
>    ("NOTE: This function doesn't seem to have a valid prologue.\n"
>     "      Try to add -fno-omit-frame-pointer tou your gcc's CFLAGS.\n");

Thanks, fixed.

Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.9.2.2
retrieving revision 1.9.2.3
diff -u -r1.9.2.2 -r1.9.2.3
--- x86-64-tdep.c       27 Apr 2002 00:11:18 -0000      1.9.2.2
+++ x86-64-tdep.c       27 Apr 2002 22:57:23 -0000      1.9.2.3
@@ -822,7 +822,7 @@
    {
      printf_filtered
        ("NOTE: This function doesn't seem to have a valid prologue.\n"
-       "      Try to add -fno-omit-frame-pointer tou your gcc's 
CFLAGS.\n");
+       "      Consider adding -fno-omit-frame-pointer to your gcc's 
CFLAGS.\n");
      omit_fp_note_printed++;
    }
   return pc;

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz

Re: GDB 5.1.92 available [patch]

[Andrew Cagney]

> Michael Elizabeth Chastain wrote:
> The last-minute x86-64 warning has a typo in it:
> 
>   printf_filtered
>    ("NOTE: This function doesn't seem to have a valid prologue.\n"
>     "      Try to add -fno-omit-frame-pointer tou your gcc's CFLAGS.\n");
> 
> Thanks, fixed.
> 
> Index: x86-64-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
> retrieving revision 1.9.2.2
> retrieving revision 1.9.2.3
> diff -u -r1.9.2.2 -r1.9.2.3
> --- x86-64-tdep.c       27 Apr 2002 00:11:18 -0000      1.9.2.2
> +++ x86-64-tdep.c       27 Apr 2002 22:57:23 -0000      1.9.2.3
> @@ -822,7 +822,7 @@
>    {
>      printf_filtered
>        ("NOTE: This function doesn't seem to have a valid prologue.\n"
> -       "      Try to add -fno-omit-frame-pointer tou your gcc's CFLAGS.\n");
> +       "      Consider adding -fno-omit-frame-pointer to your gcc's CFLAGS.\n");
>      omit_fp_note_printed++;
>    }
>   return pc;

Oops!  I should have been very clear that the 5.2 branch is frozen but I 
wasn't :-(.

Anyway, the change won't make it into 5.2.  That would mean re-building 
the tar-ball and that in turn would mean that people would again have to 
re-download and test it.

Andrew

Re: GDB 5.1.92 available [patch]

[Michal Ludvig]

Andrew Cagney wrote:
> Oops!  I should have been very clear that the 5.2 branch is frozen but I 
> wasn't :-(.

Oh, I'm sorry. My fault.

> Anyway, the change won't make it into 5.2.  That would mean re-building 
> the tar-ball and that in turn would mean that people would again have to 
> re-download and test it.

Never mind, this is not an important change.
BTW The branch for 5.2.1 will remain this one or will you create a 
different one?

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz

Re: GDB 5.1.92 available [patch]

[Andrew Cagney]

> Andrew Cagney wrote:
> Oops!  I should have been very clear that the 5.2 branch is frozen but I wasn't :-(.
> 
> Oh, I'm sorry. My fault.
> 
> Anyway, the change won't make it into 5.2.  That would mean re-building the tar-ball and that in turn would mean that people would again have to re-download and test it.
> 
> Never mind, this is not an important change.
> BTW The branch for 5.2.1 will remain this one or will you create a different one?

Same branch.
I'll update the relevant doco to mention that a very clear/separate 
branch frozen message needs to be posted.

Andrew