Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb@sources.redhat.com
Subject: Re: gdb v7.0 - user defined command's document section - space    prefixed end
Date: Fri, 13 Nov 2009 23:41:00 -0000	[thread overview]
Message-ID: <20091113143605.GA18096@caradoc.them.org> (raw)
In-Reply-To: <hd1o0t$cl2$1@ger.gmane.org>

On Fri, Nov 06, 2009 at 08:56:40PM +0300, Vladimir Prus wrote:
> Note that comment has disappeared, but it's not me -- process_next_line is given
> an empty string, presumably because readline is trying to act smart.

It's command_line_input, from top.c.  It also does history expansion.
Oh, well... for another day.

This patch is OK.  Please include changelogs...

> +  if (parse_commands)
> +    {
> +      /* If commands are parsed, we skip initial spaces. Otherwise,
> +        which is the case for Python commands and documentation
> +        (see the 'document' command), spaces are preserved.  */
> +      p = p2;
> +    }
> 
>    if (parse_commands)
>      {
> 

Want to combine the two if statements?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-11-13 14:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28  6:12 James Pandavan
2009-11-03 14:33 ` Joel Brobecker
2009-11-03 18:58   ` James Pandavan
2009-11-03 19:43     ` Joel Brobecker
2009-11-03 19:51       ` Daniel Jacobowitz
2009-11-03 22:03         ` Jim Ingham
2009-11-06 21:42         ` Vladimir Prus
2009-11-06 21:49           ` Daniel Jacobowitz
2009-11-07  1:14             ` Vladimir Prus
2009-11-13 23:41               ` Daniel Jacobowitz [this message]
2009-11-19  7:17                 ` Vladimir Prus
2009-11-04 20:47       ` Tom Tromey
2009-11-04 21:07         ` Paul Koning
2009-11-04 21:18           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113143605.GA18096@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox