From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18065 invoked by alias); 13 Nov 2009 14:36:16 -0000 Received: (qmail 18057 invoked by uid 22791); 13 Nov 2009 14:36:15 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Nov 2009 14:36:08 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 979CD10E87; Fri, 13 Nov 2009 14:36:06 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 7D9A610661; Fri, 13 Nov 2009 14:36:06 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N8xFt-00065a-LX; Fri, 13 Nov 2009 09:36:05 -0500 Date: Fri, 13 Nov 2009 23:41:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb@sources.redhat.com Subject: Re: gdb v7.0 - user defined command's document section - space prefixed end Message-ID: <20091113143605.GA18096@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb@sources.redhat.com References: <4AE7D19A.70600@googlemail.com> <20091103143305.GN4573@adacore.com> <4AF07D60.2020305@googlemail.com> <20091103194313.GS4573@adacore.com> <20091103195130.GA19931@caradoc.them.org> <20091106165450.GA24706@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00139.txt.bz2 On Fri, Nov 06, 2009 at 08:56:40PM +0300, Vladimir Prus wrote: > Note that comment has disappeared, but it's not me -- process_next_line is given > an empty string, presumably because readline is trying to act smart. It's command_line_input, from top.c. It also does history expansion. Oh, well... for another day. This patch is OK. Please include changelogs... > + if (parse_commands) > + { > + /* If commands are parsed, we skip initial spaces. Otherwise, > + which is the case for Python commands and documentation > + (see the 'document' command), spaces are preserved. */ > + p = p2; > + } > > if (parse_commands) > { > Want to combine the two if statements? -- Daniel Jacobowitz CodeSourcery