Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb@sources.redhat.com
Subject: Re: gdb v7.0 - user defined command's document section - space   prefixed end
Date: Fri, 06 Nov 2009 21:49:00 -0000	[thread overview]
Message-ID: <20091106165450.GA24706@caradoc.them.org> (raw)
In-Reply-To: <hd1ji7$sea$1@ger.gmane.org>

On Fri, Nov 06, 2009 at 07:40:39PM +0300, Vladimir Prus wrote:
> read_next_line already used to took process_commands parameter, and process_next_line
> was nothing but "Extract Function" refactoring, so it did not change that.
> 
> The process_commands parameter was added to read_next_line for exactly the reason
> Tom suggested -- to support Python. When parsing 'python' command we need to skip
> all the way to the 'end' without stripping indentation. And when not parsing 'python'
> command, process_commands should be set. Therefore, here's the patch that should fix
> this problem.  Grep claims no other problematic places.
> 
> OK?

No.  I don't think we should strip all whitespace and lines starting
with "#" from documentation, or do special handling of "else", or any
of the other bits enabled by parse_commands.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-11-06 16:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28  6:12 James Pandavan
2009-11-03 14:33 ` Joel Brobecker
2009-11-03 18:58   ` James Pandavan
2009-11-03 19:43     ` Joel Brobecker
2009-11-03 19:51       ` Daniel Jacobowitz
2009-11-03 22:03         ` Jim Ingham
2009-11-06 21:42         ` Vladimir Prus
2009-11-06 21:49           ` Daniel Jacobowitz [this message]
2009-11-07  1:14             ` Vladimir Prus
2009-11-13 23:41               ` Daniel Jacobowitz
2009-11-19  7:17                 ` Vladimir Prus
2009-11-04 20:47       ` Tom Tromey
2009-11-04 21:07         ` Paul Koning
2009-11-04 21:18           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106165450.GA24706@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox